433592 - PFS shouldn't offer Flash .xpi for Firefox 3

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Plugins, defect)

Description

[Michael Morgan [:morgamic]]

Spin-off of bug 416396 to cover the negative user-experience.

We will modify PFS to not serve the Flash .xpi for fx3 users on those platforms so they get pointed to the manual install link instead of installing the .xpi and not having it work.

Comment 1

[Marcia Knous [:marcia]]

Note that I tested this on Tiger using the latest nightly and the same things happens that happens on Linux and Windows.

Comment 2

[Michael Morgan [:morgamic]]

So we're basically not offering this .xpi for any Firefox 3 users?

Comment 3

[Michael Morgan [:morgamic]]

This is pretty terrible.

Comment 4

[Mike Connor [:mconnor]]

Yeah, it sucks.  But, at the same time, the install.js approach didn't work on Vista at all, so this isn't exactly a new problem.  We just removed the no-longer-adequate technology.

Comment 5

[Michael Morgan [:morgamic]]

So today I took a look at what I could do with the existing .exe for Flash.  I don't recommend we point at that because it doesn't improve user experience and what we really need to do is invest some time figuring out the PFS use-cases so it's an improvement over the manual install scenario.  Doesn't seem like much effort has been put into it so far.

See bug 416396 comment #75 for more on that.

I also attempted to serve the apple .dmg.zip, but that again is not an improvement over the manual install scenario -- if anything it's more confusing because the PFS dialog is inaccurate and leaves the user stranded.

So indeed, for now (or for Fx3) it looks like our best bet is to offer the manual installs.  On the other hand, I think there are some adjustments we shoudl make prior to Fx3 to prepare for better PFS logic and server-side handling.

I filed a bug 433615 to fix the lack of a version number in pfs.datasource.url for 3.0 final and subsequent releases where we'll want to key off of something besides build ids.

Comment 6

[Michael Morgan [:morgamic]]

So... ultimately we have to make a decision about what to do here short-term:

    * just offer the manual link for everyone, which degrades Fx2 users who are used to the .xpi "easy" install use-case
    * or... find which specific build IDs coming in are Fx3 vs. Fx2 and alter PFS to only offer manual link to Fx3 builds (see bug 433615 -- pfs doesn't get versions!?)

Long-term we need:

    * changes in the client so the installerLocation/installerHash stuff isn't hopelessly broken (see bug 416396 comment #75)
    * fix for bug 433615 so PFS isn't getting build ids in the appVersion part of pfs.datasource.url
    * some sort of roadmap for plugins in general

Quick fix right now would be to just offer the manual update to everyone.  Thoughts?

Comment 7

[Michael Morgan [:morgamic]]

Sorry, meant to link to bug 419928.

In particular, see bug 419928 attachment 314482 [details] to see why the external installer doesn't work even for Fx3, leaving us with no good way to have an easy-install like we did in Fx2 for any plugins.

Comment 8

[Marcia Knous [:marcia]]

Although I would not necessarily be in favor of degrading the experience for FF2 users, there are enough complaints in Hendrix with a summary such as "never-ending adobe flash player install" that I think we need to make sure that we offer the user the correct feedback when installing the Flash plugin. So I guess I would vote for the specific build ID solution noted in Comment 6.

Comment 9

[Tim Riley [:timr]]

It's critical to fix this for release.  Need smooth Flash installation.  Adding [RC2?]

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #6)
> Quick fix right now would be to just offer the manual update to everyone. 
> Thoughts?

Take the quick fix, please. I don't think we're comfortable taking 419928 at this time.

Comment 11

[Michael Morgan [:morgamic]]

Bug 433615 landed, so it looks like we should be able to utilize the version string now, which is great news.  Should have a patch Friday AM.

Comment 12

[Matt Seitz]

What about Windows XP?  The summary says "Vista", but XP also suffers from bug 416396.

Comment 13

[Michael Morgan [:morgamic]]

Matt -- that is correct, will also offer the manual install link for XP as well.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It happens for each OS. So updating the summary...

Comment 15

[Michael Morgan [:morgamic]]

Attachment: v1, disables XPIs in PFS for Firefox 3

Issues have been reported on all platforms, so my patch will disable XPIs for all Firefox 3 installations.

Comment 16

[Michael Morgan [:morgamic]]

Attachment: v2, fixed some comments

Fixed some comments.

Comment 17

[Michael Morgan [:morgamic]]

Attachment: v3, nulled licenseUrl since it doesn't apply if there is no installer plus fixed comments

EULA stuff added an additional step and isn't required for a manual link.

Comment 18

[Michael Morgan [:morgamic]]

Attachment: v4, correct patch this time...

Comment 19

[Justin Scott [:fligtar]]

Comment on attachment 323803 [details] [diff] [review]
v4, correct patch this time...

Tested and looks good. You might want to check if $appRelease is non-empty before doing the regex check for performance, but regardless r=fligtar.

Comment 20

[Michael Morgan [:morgamic]]

r14797, added check for var $appRelease.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

How do we test this?  Do we need to change the value of |pfs.datasource.url| via about:config to point to some staging server?

Comment 22

[Michael Morgan [:morgamic]]

You can change pfs.datasource.url to point to preview:
https://preview.addons.mozilla.org/services/pfs.php

Switch that in for:
https://pfs.mozilla.org/plugins/PluginFinderService.php

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

Went through this with Tony, and verified it as FIXED with:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008052912 Firefox/3.0

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

In all cases--and via both the notification bar and the in-page "Flash-needed" link--we were pointed to the "Manual Install" button which took us to the appropriate page.

Comment 24

[Michael Morgan [:morgamic]]

Push is scheduled for tonight.  Thanks Stephen.

Comment 25

[Michael Morgan [:morgamic]]

Stephen, could you re-verify this?  Had some reports that said otherwise in the press:
http://news.cnet.com/8301-13554_3-9975202-33.html

This could be related to the temporary AMO rollbacks, but would like to make sure this falls back to manual installation as expected.

Comment 26

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #25)
> Stephen, could you re-verify this?  Had some reports that said otherwise in the
> press:
> http://news.cnet.com/8301-13554_3-9975202-33.html
> 
> This could be related to the temporary AMO rollbacks, but would like to make
> sure this falls back to manual installation as expected.

The way I read that article -- "it always fell back to manual install, which worked", this wasn't broken; this is also the same experience as when I verified it with Tony in comment 23.

Anyways, I've tried again and got identical behavior -- let me know if I should be doing something different (I thought that was the approach in comment 6).

Comment 27

[Michael Morgan [:morgamic]]

Yep, verified that it doesn't hang.  Thanks.