Closed Bug 433756 Opened 12 years ago Closed 12 years ago

mozilla-central build-on-landing builds are all clobbers

Categories

(Release Engineering :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: bhearsum)

References

Details

Attachments

(1 file)

So, looking at the logs of the mozilla-central non-talos tinderboxes, it seems like any build that resulted from a checkin (i.e., a build-on-landing build rather than the 2 hour timeout) does a clobber.  This seems broken, and will slow down tinderbox cycle times a good bit.

I'm seeing this on mozilla-central-linux, mozilla-central-linux-debug, etc.

Compare the logs, for example, from today's 11:46:11 build (exactly 2 hours after the 9:46 build) with today's 12:00:59 builds (resulting from my checkin of bug 433708).

The 11:46:11 builds begin with:

removed `obj-firefox/dist/firefox-3.1a1pre.en-US.linux-i686.tar.bz2'
pulling from http://hg.mozilla.org/mozilla-central
real URL is http://hg.mozilla.org/mozilla-central/
searching for changes
no changes found

whereas the 12:00:59 builds begin with:

removed `obj-firefox/dist/firefox-3.1a1pre.en-US.linux-i686.tar.bz2'
real URL is http://hg.mozilla.org/mozilla-central/
requesting all changes
adding changesets
adding manifests
adding file changes
added 15124 changesets with 82098 changes to 34522 files
31407 files updated, 0 files merged, 0 files removed, 0 files unresolved

... and then proceed to repull all of NSPR, NSS, etc.

I'm seeing this on mozilla-central-linux, mozilla-central-win32-debug, etc.
I'll have a look at this tomorrow.
Assignee: nobody → bhearsum
Looks like this is a Buildbot bug. I'm working on a patch.
This patch worked fine in a local test. I'm going to test it on staging now.
This patch totally fixed the issue. I'll get this checked in and deployed ASAP.

Upstream patch is here: http://buildbot.net/trac/ticket/277
Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #321066 - Flags: review?(rcampbell)
Attachment #321066 - Flags: review?(rcampbell) → review+
Comment on attachment 321066 [details] [diff] [review]
[checked in] fix Mercurial Source class

Checking in buildbot/slave/commands.py;
/cvsroot/mozilla/tools/buildbot/buildbot/slave/commands.py,v  <--  commands.py
new revision: 1.4; previous revision: 1.3
done
Attachment #321066 - Attachment description: potential patch → [checked in] fix Mercurial Source class
I've deployed on a couple of slaves, waiting for builds on the others' to finish before I can deploy on the rest of them.
Alright, it's been deployed everywhere - this is fixed.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.