433935 - [mozilla-central] DOMI extension version wasn't bumped

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The DOM inspector extension version wasn't bumped on mozilla-central along with the version bump, so a DOMI built in mozilla-central isn't compatible with the build produced.

(As somebody who needs DOMI to get work done (like debugging bug 433883), I'm really getting tired of running into this.)

Comment 1

[Shawn Wilsher :sdwilsh]

bah - this was fixed in CVS by timeless.  I was under the impression that cvs trunk was still being merged into mozilla-central; is that wrong?

Comment 2

[Alex Vincent [:WeirdAl]]

sdwilsh:  see bug 433426 comment 4 - might this be fallout from that?

Comment 3

[Shawn Wilsher :sdwilsh]

wait, nevermind.  Silly me...

mozilla-central's version is 3.1a1pre, which DOMi doesn't support.  I'll have a patch today or tomorrow.  Looks like I get to try and check something into mozilla-central sooner than later...

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This should become part of the standard version bump routine, not something that you have to do a few days later.

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Any reason the DOMI file can't be preprocessed to make this bump automatic ?

Comment 7

[Shawn Wilsher :sdwilsh]

It used to be pre-processed when it was part of the default build.  However, that is no longer the case, so the automatic preprocessing was removed.

Comment 8

[(not currently active) Ted Mielczarek]

Why don't we just change it back, then?

Comment 9

[Shawn Wilsher :sdwilsh]

because I'm not fond/comfortable of doing a bump without first making sure it works on that version.

Comment 10

[(not currently active) Ted Mielczarek]

I would say that if you're making it difficult for dbaron to do work, then you're negating any benefit you might get from trying to manually keep the maxVersion updated.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Though I'm not sure how you preprocess in all the appropriate app version numbers for all the different apps in the install.rdf.

Comment 12

[[e-mail]]

Comment on attachment 321774 [details] [diff] [review]
v1.0

rs=me (you can't expect me to review this when I don't have a 3.1a1pre tree yet...

Comment 13

[Shawn Wilsher :sdwilsh]

(In reply to comment #12)
> (From update of attachment 321774 [details] [diff] [review])
> rs=me (you can't expect me to review this when I don't have a 3.1a1pre tree
> yet...
Sorry - I'm really lacking peers ;)

Anyone know the policy about pushing to mozilla-central?

Comment 14

[Shawn Wilsher :sdwilsh]

After much fun, I got this pushed.

http://hg.mozilla.org/mozilla-central/index.cgi/rev/a9a074d14cb2