434013 - JS1.8 should be buildable by a C++ compiler

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

It looks like bug 357016 regressed in CVS and nobody noticed.

If JS1.8 (bug 380236) ships out of mozilla-central or a branch thereof, this is WORKSFORME.  If it ships out of CVS, this needs a trivial fix.  See bug 433426 comment 9 for details.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Fix

With this patch, it's possible to build SpiderMonkey 1.8 (CVS, not quite yet released) with

  make CC=g++ JS_EDITLINE=0 -f Makefile.ref

You have to disable editline because it's still C and it contains a lot of fun idioms that are not valid C++.

Given that we're not going to fix editline, and SpiderMonkey 1.8.1 is all C++ all the time, and no one has specifically asked me for this feature, I'm going to leave this out of SM1.8 RC1.  I might change my mind if enough C++ fans come out of the woodwork before SM1.8 final is released, but it seems unlikely.

Comment 2

[Brendan Eich [:brendan]]

Our numerology doesn't make sense according to any system that wants at least y to change in x.y[.z] for a required toolchain change, but oh well. I'm all for C++ in 1.8.1. Advise against taking any risk trying for it in 1.8, no matter the fan noise.

/be