436872 - Build js shell on Windows in mozilla-central/tracemonkey

Status: RESOLVED DUPLICATE of bug 445243

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: partial patch for rules.mk, config/WINNT*

The config/WINNT* files lack a definition for CXX which results in an attempt to compile cpp files using g++.

rules.mk has a typo where jsinterp.c is used to build jsinterp.obj.

With these errors fixed, the build still fails with:

js.cpp(2032) : error C2664: 'JS_ValueToInt32' : cannot convert parameter 3 from 'intN *' to 'int32 *'
        Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast

Comment 1

[Jason Orendorff [:jorendorff]]

The patch looks good to me.  I'll try it out on my Vista VM today.

That last error sounds like an Intel64 bug.

Comment 2

[Bob Clary [:bc] (inactive)]

It was actually with a 32bit Windows XP VM although the host is 64bit.

Comment 3

[Jason Orendorff [:jorendorff]]

Sorry, my Vista VM won't boot.  I need to reinstall.  If anyone else wants to take this review, please feel free.

Comment 4

[Bob Clary [:bc] (inactive)]

from what i understand, actionmonkey is a dead end, but this is also applicable to tracemonkey which is not. Can I get an r+ or r- from someone?

Comment 5

[Brendan Eich [:brendan]]

"actionmonkey is a dead end" is not true, if we are doing anything like using an MMgc-style GC -- which I thought was the plan. If not, then XPCOMGC is a dead end and CC and ref-counting will live forever.

Please let's not throw away work we think we need to build on. Whether in the final analysis "actionmonkey" the repository dies, but patches from it live on in a more central repo, I do not care. The "actionmonkey is tamarin in SpiderMonkey clothing, via a big-bang integration after years of work" meme is dead, but that is not the same as "actionmonkey is a dead end". AM is needed for XPCOMGC, last I heard.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

Ok. Either I misremembered what I was told or someone misspoke. Which repositories should I care about? mozilla-central, tracemonkey, actionmonkey, what else? Do I need to file separate bugs on each repository? How do we track where the fixes have landed?

Comment 7

[Brendan Eich [:brendan]]

Jason: is actionmonkey on hiatus while you do DOM perf work for 3.1? Where is Jason doing jegc work?

/be

Comment 9

[Jason Orendorff [:jorendorff]]

Yes, actionmonkey is on hiatus.  I don't know where jegc is happening.