434188 - calIDatetime::icalString should enforce timezone

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Daniel Boelzle [:dbo]]

While developing on bug 363191, I experienced some assertions on using the calDatetime::icalString setter in guessSystemTimezone(). The icalString doesn't enforce the timezone based on the ical string (i.e. either UTC or floating), but IMO it should. Otherwise callers cannot be sure whether a previously set timezone persists initializing via the icalString setter.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: fix

This enforces a timezone (either UTC or floating) when using the icalString setter and fixes some warnings to actually go into the warning section of the console (instead of the message section).

Comment 2

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 321406 [details] [diff] [review]
fix

Did you check all places where icalString is set and no timezone is specifically set, to see if it relies on the timezone staying the way it was before?

If so, r=philipp

Comment 3

[Daniel Boelzle [:dbo]]

I've looked over all icalString occurrences, and hope I spotted all.

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Comment 4

[Andreas Treumann]

Checked via mxr.mozilla.org -> VERIFIED