Closed
Bug 434748
Opened 17 years ago
Closed 17 years ago
Make mailnews/base/search compile with frozen linkage
Categories
(MailNews Core :: Search, defect)
MailNews Core
Search
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
2.14 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Following on from bug 407295 and others, there's just a few more changes we need in mailnews/base/search to get it compiling.
Attachment #321768 -
Flags: superreview?(bienvenu)
Attachment #321768 -
Flags: review?(bienvenu)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 321768 [details] [diff] [review]
The fix
r/sr=bienvenu, but just out of curiousity, why do we need ctype.h? Not because we changed IsUTF8 to MsgIsUTF8...
Attachment #321768 -
Flags: superreview?(bienvenu)
Attachment #321768 -
Flags: superreview+
Attachment #321768 -
Flags: review?(bienvenu)
Attachment #321768 -
Flags: review+
|
Assignee | |
Comment 2•17 years ago
|
||
(In reply to comment #1)
> (From update of attachment 321768 [details] [diff] [review])
> r/sr=bienvenu, but just out of curiousity, why do we need ctype.h? Not because
> we changed IsUTF8 to MsgIsUTF8...
>
I responded on IRC. Basically they aren't related and its just an extra part of the tidy up required after bug 407925.
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•