Closed Bug 435020 Opened 16 years ago Closed 16 years ago

A patch formatted by git-format-patch is sent incorrectly by Thunderbird; does not follow it's draft

Categories

(Thunderbird :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 204478

People

(Reporter: jwhite, Unassigned)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.12) Gecko/20080129 Iceweasel/2.0.0.12 (Debian-2.0.0.12-1)
Build Identifier: Multiple; on Ubuntu Hardy 2.0.0.14, and on Debian/Lenny 2.0.0.9

I use git-format-patch | git-imap-send to create an email in my drafts folder.

I edit the draft and review it; it is perfect; perfectly formatted, everything.

I then click send, and the actual email *sent* is *not* what was contained in the draft.  Specifically, spaces are injected prior to some lines, which essentially
makes the patch unusable via diff and it doesn't work.

Using git-format-patch --attach does work, but it seems it shouldn't be necessary.

I will attach an example of a draft I used and the resulting sent email

Reproducible: Sometimes

Steps to Reproduce:
git-format-patch .... --stdout | git-imap-send
click on drafts folder, review the draft email, confirm it is correct
click send
click on sent folder, review what actually was sent
Actual Results:  
The message actually sent will sometimes, not always, but often, have spaces
injected prior to lines, thereby mashing up the diff.

Expected Results:  
For the message actually sent to be identical to my draft.

I will attach a draft and a sent email that shows the issue.
Attached file A sample draft email
A sample draft email that fails.
Arg!  I'm having a hard time getting an exact useful reproduction of this bug.

That is, if I make a draft message just as I have been all along, save that draft
(so as to attach it here), and then send the message back to myself, the
resulting message is correct.

The problem does not occur :-(.  I will make some effort to pin down exactly what varies to cause this (e.g. not saving the draft first or sending it outside my own domain).

Ah.  This must be a side effect of flowing the text.  

Hrm.  Is there any chance the flow logic could be adapted to detect these
cases and not kick in?  (For that matter, is the flow logic documented anywhere; playing with sending email, I can't figure out just how it works...)
Yup, looks like it.

Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: