findbar keys highlight.accesskey conflicts with beginning of line mac os x keybinding

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
Find Toolbar
P1
normal
RESOLVED FIXED
9 years ago
12 days ago

People

(Reporter: Mike Polo, Assigned: mikedeboer)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
PowerPC
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
str
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14

Mac OS X uses emacs keybindings for all dialog boxes.

some very common keybindings are 
control-p previous line
control-n next line
control-a beginning of line
control-e end of line

however when the findbar is open (command-F) the control-a key
is used to toggle "Highlight all" function on and off.

You should change the "highlight all" accesskey to a different key


Reproducible: Always

Steps to Reproduce:
1. browse to a web page
2. search for text within the page using command-f
3. use the ctrl-a key to go to the beginning of a line in any browser
   field (url bar, find area, etc)
Actual Results:  
the rather obscure function "highlight all" in the findbar will toggle on and off

Expected Results:  
cursor should move to beginning of line


I believe the basic text editing keystrokes should NOT be
repurposed to other functions

control-a should be beginning of line.

additionally, control-n and control-p move to previous and next matches.
This should be changed too.  I believe text boxes should take precedence.

If I happen to have the findbar open, and I type text into a text box,
hitting control-p and control-n instead of moving around in the text
box will start doing find features.

for instance, command-g correctly goes to the next match.  This is ok.
however control-n should not do this too.

the definition of control-a seems to be in:
/Applications/Firefox.app/Contents/MacOS/chrome/en-US.jar
in:
locale/en-US/global/findbar.dtd
as:
highlight.accesskey
next.accesskey
previous.accesskey
Product: Firefox → Toolkit
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P1
Blocks: 1271782
Comment hidden (mozreview-request)
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED

Comment 2

9 months ago
mozreview-review
Comment on attachment 8808611 [details]
Bug 435326 - change accesskey for en_US 'Highlight All' from 'a' to 'l', to stop overriding Emacs-style input keybindings.

https://reviewboard.mozilla.org/r/91412/#review91246

ctrl-h seems to be emacs-style keybinding for backspace?

TBH, h and a are the most obvious here. Not sure what else to use or if we should just give up. Certainly don't think we should use "i" or whatever on Windows/Linux just because OS X and emacs are "special".
Attachment #8808611 - Flags: review?(gijskruitbosch+bugs)
How about 'l'?

Comment 4

9 months ago
mozreview-review
Comment on attachment 8808611 [details]
Bug 435326 - change accesskey for en_US 'Highlight All' from 'a' to 'l', to stop overriding Emacs-style input keybindings.

https://reviewboard.mozilla.org/r/91412/#review91252

r=me for using 'l', then, I guess.
Attachment #8808611 - Flags: review+
Comment hidden (mozreview-request)

Comment 6

9 months ago
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9796c87f3a2d
change accesskey for en_US 'Highlight All' from 'a' to 'l', to stop overriding Emacs-style input keybindings. r=Gijs

Comment 7

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9796c87f3a2d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Comment 8

9 months ago
Just a thought. Should this be for Mac OS builds only? Ctrl+a is a Windows function and will most likely be used instinctively by Windows users when attempting to "highlight all". With this change, you will be forcing Windows users to change what they would naturally do because of an issue that, AFAICT, is strictly on Mac OS.

Comment 9

9 months ago
(In reply to WildcatRay from comment #8)
> Just a thought. Should this be for Mac OS builds only? Ctrl+a is a Windows
> function and will most likely be used instinctively by Windows users when
> attempting to "highlight all". With this change, you will be forcing Windows
> users to change what they would naturally do because of an issue that,
> AFAICT, is strictly on Mac OS.

No, this is an accesskey. On Windows you'd invoke it with alt-a. It's different from the "select all" windows function which has the shortcut (which isn't the same as an accesskey) ctrl-a. We're not changing the latter, only the former.
Depends on: 1335218
QA Whiteboard: [good first verify]

Comment 10

4 months ago
Windows user here.  Just updated to Firefox 52.0.  The key sequence "Ctrl-F, Alt-A" no longer invokes "Highlight All" like it used to.  Now the sequence is "Ctrl-F, Alt+L".  Maybe this was an intentional change, but not a good one.  It changed an easy one-handed sequence into a complicated two-handed sequence that forces me to take my hand off the mouse for a basic function that's used quite often.

Updated

4 months ago
Depends on: 1351534

Comment 11

2 months ago
Same here. This broke a very well working and convenient shortcut key, and replaced it with a cumbersome to use one. Please consider bringing ALT-A back for the "Select-All" function.
If you have to get voting on this one I'd guess the vast majority would prefer Alt-A than Alt-L as it's very easy to press with just one hand.
If this still requires further per-user customization I'd suggest making this a user-configurable option.

Comment 12

2 months ago
Linux user here and I also don’t understand how a MacOS-only issue could trigger a decision that harm the usability for users on all platforms. "Ctrl-F, Alt-A" was a convenient one-handed sequence that is not even close to the effort to do a "Ctrl-F, Alt-L", that requires to take the hand off the mouse and look to the keyboard, entirely breaking the work flow.
It makes me wonder with how many users in consideration this was decided. Please consider, if is not possible to bring it back as it efficiently was for years, at least give us the option to customize it.

Comment 13

12 days ago
I won't go on endlessly about why I feel the change of "Alt-A" to "Alt-L", apart from the obvious inconvenience to Firefox users on every platform that is not Macintosh. (Do they still use their full name?)
Please do change this back for the benefit of the *majority* of Firefox users.  If you would like to do something special for a Mac version of Firefox, then please do so - just not at the inconvenience of the *majority* of Firefox users.
Thank you.
You need to log in before you can comment on or make changes to this bug.