Closed Bug 435390 Opened 12 years ago Closed 12 years ago

Style sheet missing from iMip/iTip

Categories

(Calendar :: Lightning Only, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla.mozilla.org-3, Assigned: ssitter)

References

Details

(Keywords: regression, Whiteboard: [good first bug])

Attachments

(2 files)

iMip/iTip invitations used to be styled (among other things to preserve newlines - bug 265971). This styling recently disappeared.

The Error Console contains the following:

Security Error: Content at imap://foo%40example%2Eorg@mail.example.org:143/fetch%3EUID%3E/INBOX%3E344494 may not load or link to chrome://lightning/skin/imip.css.


Thunderbird: version 3.0a2pre (2008052003)
Lightning: Nightly trunk build from 22-May-2008 21:38 PST
Does this happens with Thunderbird 2 and Lightning 0.9pre too?

Can you specify the regression range for Thunderbird? This doesn't sound like it's caused by a Lightning change but rather by some change in the Mozilla Toolkit.
Looks like Thunderbird had the same issue with their own .css files, see Bug 428767 and Bug 428996.
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [good first bug]
This patch exposes only imip.css to content using a similar approach as used in Bug 428996 for Thunderbird.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #330252 - Flags: review?(philipp)
Comment on attachment 330252 [details] [diff] [review]
exposes imip.css to content

>+% content messagebody %content/messagebody/
>+% content messagebody %content/messagebody/ contentaccessible=yes
I'd prefer something lightning-specific, maybe ltn-contentaccessible ?
Why do we need the content line twice, once with contentaccessible and once without?

>+% override chrome://messagebody/skin/imip.css chrome://lightning/skin/imip.css
Possibly we could use a different stylesheet instead of overriding?
Attachment #330252 - Flags: review?(philipp) → review+
(In reply to comment #5)
> I'd prefer something lightning-specific, maybe ltn-contentaccessible ?

Sure, it could be renamed if it causes any troubles. I just choose the same name because messagebody very clearly matches it's purpose.

> Why do we need the content line twice, once with contentaccessible and once
> without?

The line is required two times to make it work on branch too, see the link posted in Comment #3.

> Possibly we could use a different stylesheet instead of overriding?

If that means moving files or creating another .jar file just for that purpose the override is easier. In addition theme authors that might support Lightning too don't need to update.
I left your patch as is for checkin, we can fix later if trouble comes up.

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
The fix causes a JavaScript warning (Unrecognized chrome registration modifier 'contentaccessible=yes') in Thunderbird 2 although it corresponds to the recommendation at <http://developer.mozilla.org/en/docs/Chrome_Registration#contentaccessible>.
Attachment #331471 - Flags: review?(philipp)
Attachment #331471 - Flags: review?(philipp) → review+
Attachment #331471 - Attachment description: fix JavaScript warning → [checked in] fix JavaScript warning
Depends on: 491868
You need to log in before you can comment on or make changes to this bug.