435414 - Upgrade to sqlite 3.5.9

Status: RESOLVED WONTFIX

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Shawn Wilsher :sdwilsh]

We may end up going with 3.5.10 if something comes out of bug 421482 from the sqlite folks, but let's look at 3.5.9 for now.

Comment 1

[Mike Schroepfer]

Let's get perf numbers to make sure the regression in 3.5.8 is resolved in 3.5.9

Comment 2

[Andreas Goetz]

Would like to see if this potentially fixes bug 425664- would be happy to test.

Comment 3

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

By giving this attachment r+, you also give me permission to push this change:
http://hg.mozilla.org/users/sdwilsh_shawnwilsher.com/storage-async/index.cgi/file/580c599f7f91/sqlite.3.5.9

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> Let's get perf numbers to make sure the regression in 3.5.8 is resolved in
> 3.5.9
Note: the sqlite folks do perf tests on each release, and they added perf tests that would have caught the regression they caused in 3.5.8.  3.5.9 has been out for some time with no reported performance hits.

Comment 5

[Mike Schroepfer]

Can we get this landed on mozilla-central so we can make sure there are no perf issues in our environment.  if there are no issues I'd be inclined to try this for a 3.0.1.

Comment 6

[Shawn Wilsher :sdwilsh]

Once this gets review, I'll push it.

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 324683 [details] [diff] [review]
v1.0

shaver is really busy, so switching to mconnor

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 324683 [details] [diff] [review]
v1.0

r=mconnor

Comment 9

[Shawn Wilsher :sdwilsh]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/1d72dd9072ab
http://hg.mozilla.org/mozilla-central/index.cgi/rev/e741c9c886f7

Comment 10

[Shawn Wilsher :sdwilsh]

Comment on attachment 324683 [details] [diff] [review]
v1.0

branch will need the following changesets:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/cabc20ec70a2
http://hg.mozilla.org/mozilla-central/index.cgi/rev/e741c9c886f7
http://hg.mozilla.org/mozilla-central/index.cgi/rev/1d72dd9072ab

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 324683 [details] [diff] [review]
v1.0

Let's get this in on cvsroot. Can you please blog when it goes in so that our nightly testers know about it and know what to look for? Thanks.

Comment 12

[Shawn Wilsher :sdwilsh]

Checking in db/sqlite3/src/sqlite.def;
new revision: 1.12; previous revision: 1.11
Checking in db/sqlite3/src/sqlite3.c;
new revision: 1.19; previous revision: 1.18
Checking in db/sqlite3/src/sqlite3.h;
new revision: 1.22; previous revision: 1.21
Checking in configure.in;
new revision: 1.1994; previous revision: 1.1993
Checking in db/sqlite3/README.MOZILLA;
new revision: 1.28; previous revision: 1.27

Comment 13

[Shawn Wilsher :sdwilsh]

beltzner wanted me to ask the places folks to give these builds the run through with your large places profile data.

Comment 14

[Marcia Knous [:marcia]]

It would be great if QA could get some of these large places profiles to test, especially in light of the fact that we will soon be doing major update. We have some complex profiles but perhaps not as complex as the ones that they have.

Comment 15

[Shawn Wilsher :sdwilsh]

This may end up being WONTFIX and we'll try 3.6.0.  Backed out for bug 442949.

Comment 16

[Mike Schroepfer]

Um - this is in 3.0.1 do we need to be concerned before we ship?

Comment 17

[Shawn Wilsher :sdwilsh]

(In reply to comment #16)
> Um - this is in 3.0.1 do we need to be concerned before we ship?
I've pinged beltzner a few times today but got no response.  Someone just suggested I e-mail [e-mail] (didn't even know about that!), so doing that now.

Comment 18

[Shawn Wilsher :sdwilsh]

I'm going to mark this as WONTFIX, but note that the fix is still in CVS.  Drivers decided it was worth keeping there.

The bug to upgrade to sqlite 3.6.0 is bug 445042.