Closed Bug 435414 Opened 12 years ago Closed 12 years ago

Upgrade to sqlite 3.5.9

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX
mozilla1.9.1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

(Keywords: fixed1.9.0.1)

Attachments

(1 file)

We may end up going with 3.5.10 if something comes out of bug 421482 from the sqlite folks, but let's look at 3.5.9 for now.
Flags: in-testsuite-
Flags: in-litmus-
Flags: blocking1.9.0.1?
Let's get perf numbers to make sure the regression in 3.5.8 is resolved in 3.5.9
Would like to see if this potentially fixes bug 425664- would be happy to test.
Attached patch v1.0Splinter Review
By giving this attachment r+, you also give me permission to push this change:
http://hg.mozilla.org/users/sdwilsh_shawnwilsher.com/storage-async/index.cgi/file/580c599f7f91/sqlite.3.5.9
Attachment #324683 - Flags: review?(shaver)
(In reply to comment #1)
> Let's get perf numbers to make sure the regression in 3.5.8 is resolved in
> 3.5.9
Note: the sqlite folks do perf tests on each release, and they added perf tests that would have caught the regression they caused in 3.5.8.  3.5.9 has been out for some time with no reported performance hits.
Flags: blocking1.9.1?
Whiteboard: [has patch][needs review shaver]
Blocks: 417037
Can we get this landed on mozilla-central so we can make sure there are no perf issues in our environment.  if there are no issues I'd be inclined to try this for a 3.0.1.
Once this gets review, I'll push it.
Comment on attachment 324683 [details] [diff] [review]
v1.0

shaver is really busy, so switching to mconnor
Attachment #324683 - Flags: review?(shaver) → review?(mconnor)
Whiteboard: [has patch][needs review shaver] → [has patch][needs review mconnor]
Comment on attachment 324683 [details] [diff] [review]
v1.0

r=mconnor
Attachment #324683 - Flags: review?(mconnor) → review+
Whiteboard: [has patch][needs review mconnor] → [has patch][has review][can land]
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/1d72dd9072ab
http://hg.mozilla.org/mozilla-central/index.cgi/rev/e741c9c886f7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
Target Milestone: --- → mozilla1.9.1
Comment on attachment 324683 [details] [diff] [review]
v1.0

Let's get this in on cvsroot. Can you please blog when it goes in so that our nightly testers know about it and know what to look for? Thanks.
Attachment #324683 - Flags: approval1.9.0.1? → approval1.9.0.1+
Checking in db/sqlite3/src/sqlite.def;
new revision: 1.12; previous revision: 1.11
Checking in db/sqlite3/src/sqlite3.c;
new revision: 1.19; previous revision: 1.18
Checking in db/sqlite3/src/sqlite3.h;
new revision: 1.22; previous revision: 1.21
Checking in configure.in;
new revision: 1.1994; previous revision: 1.1993
Checking in db/sqlite3/README.MOZILLA;
new revision: 1.28; previous revision: 1.27
Keywords: fixed1.9.0.1
beltzner wanted me to ask the places folks to give these builds the run through with your large places profile data.
Keywords: qawanted
It would be great if QA could get some of these large places profiles to test, especially in light of the fact that we will soon be doing major update. We have some complex profiles but perhaps not as complex as the ones that they have.
Flags: blocking1.9.1?
Flags: blocking1.9.1+
Flags: blocking1.9.0.1?
Flags: blocking1.9.0.1+
Depends on: 442949
This may end up being WONTFIX and we'll try 3.6.0.  Backed out for bug 442949.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Um - this is in 3.0.1 do we need to be concerned before we ship?
(In reply to comment #16)
> Um - this is in 3.0.1 do we need to be concerned before we ship?
I've pinged beltzner a few times today but got no response.  Someone just suggested I e-mail release-drivers@mozilla.org (didn't even know about that!), so doing that now.
Keywords: qawanted
I'm going to mark this as WONTFIX, but note that the fix is still in CVS.  Drivers decided it was worth keeping there.

The bug to upgrade to sqlite 3.6.0 is bug 445042.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → WONTFIX
No longer blocks: 417037
Depends on: 446208
You need to log in before you can comment on or make changes to this bug.