435570 - Let's add all field descriptions in field-descs.none.tmpl to make them localizable

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Cédric Corazza]

Per comment from https://bugzilla.mozilla.org/show_bug.cgi?id=435504#c5 , there is a mix of English and localized terms in boolean charts.
So let's add all the field descriptions in field-descs.none.tmpl to avoid this.
I will provide a patch this weekend.

Comment 1

[Cédric Corazza]

Attachment: Patch adding field descs

Comment 2

[Frédéric Buclin]

Comment on attachment 322379 [details] [diff] [review]
Patch adding field descs

>+                   "delta_ts"                => "Changed",

The only one I'm worried about is delta_ts. In 3.1.4, this field means "Last changed date". Now "Changed" will be displayed instead, which is much less clear about what this field is about. Maybe should we rename it to "Last changed date"? We should investigate where this field is used. r=LpSolit anyway as delta_ts was already defined this way in the template, so this is not a regression due to this patch.

Comment 3

[Frédéric Buclin]

I would tend to say that the fielddefs.description column in the DB should go away for Bugzilla 4.0, and only keep and use descriptions in field-descs.none.tmpl, but this wouldn't work for custom fields. Bah :(

Comment 4

[Max Kanat-Alexander]

(In reply to comment #3)
> I would tend to say that the fielddefs.description column in the DB should go
> away for Bugzilla 4.0, and only keep and use descriptions in
> field-descs.none.tmpl, but this wouldn't work for custom fields. Bah :(

  We could make it NULL for all the non-custom fields, though. That would at least save us having to keep it updated in Field.pm.

Comment 5

[Frédéric Buclin]

tip:

Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v  <--  field-descs.none.tmpl
new revision: 1.27; previous revision: 1.26
done


3.1.4:

Checking in template/en/default/global/field-descs.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v  <--  field-descs.none.tmpl
new revision: 1.25.2.1; previous revision: 1.25
done