DragDrop Indicator broken in menupopup of folder on Bookmarks Toolbar placed on toolbox,when restart Firefox.

RESOLVED FIXED in Firefox 3.1b1

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: Alice0775 White, Assigned: mak)

Tracking

unspecified
Firefox 3.1b1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008052606 Minefield/3.0pre Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008052606 Minefield/3.0pre

When I try dragging a link(bookmark/identity/link) onto menupopup of folder on
the Bookmarks Toolbar placed on toolbox,

At the positions more than the number that there was bookmarks/folders before reboot Fx.

A: Drag over bookmark/folder, dragdrop Indicator will is broken.
b: Drag over folder, the folder does not expand.





Reproducible: Always

Steps to Reproduce:
1. Start Firefox  in new profile.
2. Create a folder named "AAA" in the "Bookmarks Toolbar" placed on toolbox,
3. Add 3 Bookmarks in the folder "AAA", Now "AAA" has 3 bookmarks.
4. Restart Firefox
5. Add 1 or more Bookmarks in the folder "AAA", Now "AAA" has more than 3 bookmarks.
6. Drag a link/Bokmark into dropdown menu of "AAA"

Actual Results:  
"Dropdown indicator" is not displayed at the positions more than the number that there was bookmarks/folders before reboot Fx.

Expected Results:  
"Dropdown indicator" should be displayed.

I think _endMarker(in places\menu.xml) may be broken in Bookmarks toolbar.

And this bug may cause serious Bug 435742 also.
(Reporter)

Comment 1

10 years ago
Created attachment 322617 [details]
This re-calculates _endMarker for existing menupopup again.

dis patch is for chrome://browser/content/browser.js.
I tested on Windows XP sp3 only.
(Reporter)

Comment 2

10 years ago
s/dis/This

My English is not well and is sorry.
(Reporter)

Comment 3

10 years ago
Created attachment 322619 [details] [diff] [review]
Re-calculates _endMarker for existing menupopup again.
Attachment #322617 - Attachment is obsolete: true

Comment 4

10 years ago
That patch also fixes bug 435742 (tested on linux). Alice, could you ask someone (e.g. mano@mozilla.com) for a review of your patch, please?
Blocks: 435742
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 5

10 years ago
Sorry, I do not know how to request review.  

Comment 6

10 years ago
You can ask for review by following the "Details" link next to your patch in the "Attachments" box on this page. There you can set the review flag to "?" and insert the mail address of the one to review your patch. Usually, you can find an appropriate reviewer on one of these pages
  http://www.mozilla.org/projects/firefox/review.html
  http://www.mozilla.org/hacking/reviewers.html
  http://www.mozilla.org/owners.html
or you can check who often does check-ins to the file(s) your patch changes. (see http://lxr.mozilla.org).

By the way, chrome://browser/content/browser.js is not a single file in the Firefox source. The code that your patch changes is in browser/base/content/browser-places.js (you can find the file here: http://lxr.mozilla.org/mozilla/source/browser/base/content/browser-places.js , click on "Raw output" to download the file). Maybe you could make a patch against that file?
(Reporter)

Comment 7

10 years ago
Thank you very much for detailed explanation. 
 
However, it does not seem to be possible to be my English. 
And I am really ignorant of the system of source code.

You please request it to reviewer.  
I think that it is the earliest solution to do so.

Comment 8

10 years ago
Created attachment 322655 [details] [diff] [review]
patch by Alice White against browser-places.js

This is the patch above against browser/base/content/browser-places.js instead of chrome://browser/content/browser.js.
Attachment #322619 - Attachment is obsolete: true
Attachment #322655 - Flags: review?(mano)
(Assignee)

Comment 9

10 years ago
Comment on attachment 322655 [details] [diff] [review]
patch by Alice White against browser-places.js

clearing review request, should be fixed by bug 418671, however we should ensure markers are always correct rather than work-arounding it, in this case the endMarker is not updated correctly in the viewer and that's the culprit.

Thank you for the workaround hwv
Attachment #322655 - Flags: review?(mano) → review-
(Assignee)

Updated

10 years ago
Depends on: 418671
(Assignee)

Updated

10 years ago
Duplicate of this bug: 435742
(Assignee)

Updated

10 years ago
No longer blocks: 435742
(Assignee)

Comment 11

10 years ago
fixed by patch in bug 418671

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre)
Gecko/20080920033605 Minefield/3.1b1pre
Assignee: nobody → mak77
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
(Assignee)

Updated

10 years ago
OS: Windows XP → All
Hardware: PC → All
As Marco pointed out on IRC we don't have d&d tests yet. Means, we should add this d&d behavior as a testcase on Litmus.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.