Closed
Bug 436059
Opened 17 years ago
Closed 17 years ago
Zoom to relevant section
Categories
(Firefox for Android Graveyard :: Panning/Zooming, enhancement, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0m5
People
(Reporter: christian.bugzilla, Assigned: Gavin)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.93 KB,
patch
|
pavlov
:
review+
|
Details | Diff | Splinter Review |
|
||
Updated•17 years ago
|
Assignee: nobody → gavin.sharp
Priority: -- → P1
|
Reporter | |
Updated•17 years ago
|
Target Milestone: Fennec M3 → Fennec M5
|
Assignee | |
Comment 1•17 years ago
|
||
Needs a bit more work on defining "relevant section" (right now it just zooms to whatever element was double clicked on, which isn't optimal - glazoom might have some useful code for this). Also doesn't fix some existing bugs with panning constraints while zoomed.
Double clicking still doesn't work on the device, though, so this isn't testable there without an extra patch. I guess I'll have to revive mfinkle's double click simulating code or something until we fix that.
(Apologies for some of the renaming and coordinate changes, think things are clearer this way though.)
Attachment #329143 -
Flags: review?
|
|
Assignee | |
Updated•17 years ago
|
Attachment #329143 -
Flags: review? → review?(pavlov)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 329143 [details] [diff] [review]
zoom to element
looks good.
Attachment #329143 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Attachment #329143 -
Attachment is obsolete: true
Attachment #329161 -
Flags: review?(pavlov)
|
|
Assignee | |
Comment 4•17 years ago
|
||
Attachment #329161 -
Attachment is obsolete: true
Attachment #329164 -
Flags: review?(pavlov)
Attachment #329161 -
Flags: review?(pavlov)
|
|
||
Updated•17 years ago
|
Attachment #329161 -
Flags: review+
|
|
||
Updated•17 years ago
|
Attachment #329164 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
https://hg.mozilla.org/mobile-browser/index.cgi/rev/1b03ce8369fe
https://hg.mozilla.org/mobile-browser/index.cgi/rev/cc6f9da463bd
Filed bug 444857 (figure out why double clicks aren't firing) and bug 444858 (improving zoom to element behavior).
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Component: General → Panning/Zooming
You need to log in
before you can comment on or make changes to this bug.
Description
•