436078 - Zoom to fit page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, enhancement, P2)

Description

[Christian Sejersen]

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Don't really know how this differs from bug 436079. That made us zoom on load such that the page fits in the window horizontally.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Is it possible to get the zoom changed and not be able to easily get back to the initial "zoom to fit page" done on the initial page load? If so, then having a way to get back to that zoom level would be handy.

Comment 3

[Stuart Parmenter]

this is sort of in -- should we mark this fixed?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> Is it possible to get the zoom changed and not be able to easily get back to
> the initial "zoom to fit page" done on the initial page load? If so, then
> having a way to get back to that zoom level would be handy.

Yeah, we can expose the "initialZoom" as a readonly property on deckbrowser, or something.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: add initialZoom

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I guess it should probably be "initialZoomLevel" to match "zoomLevel"

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #5)
> Created an attachment (id=330584) [details]
> add initialZoom
> 

Can we skip this patch (or move it into a new bug) and just refactor the code to zoom the initial page load into a "zoomToPage" method in deckbrowser? And close this bug.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

OK I'll move this to another bug.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 330584 [details] [diff] [review]
add initialZoom

this was moved to a different bug

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

verfied with beta3