Status
()
People
(Reporter: Raúl Porcel, Assigned: Raúl Porcel)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(URL)
Attachments
(1 attachment, 2 obsolete attachments)
|
3.08 KB,
patch
|
Details | Diff | Splinter Review |
Same as bug 417345 and bug 411292
|
(Assignee) | |
Comment 1•10 years ago
|
||
Created attachment 322801 [details] [diff] [review] hppa.patch This should do it(i've tested it)
Assignee: nobody → armin76
Status: NEW → ASSIGNED
Attachment #322801 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 322801 [details] [diff] [review] hppa.patch >Index: configure.in >=================================================================== >- if test "$CPU_ARCH" != "ia64" && test "$CPU_ARCH" != "sparc" \ >+ if test "$CPU_ARCH" != "hppa" && test "$CPU_ARCH" != "ia64" && test "$CPU_ARCH" != "sparc" \ > && test -z "$INTEL_CC"; then >- # don't use -Wcast-align on ia64 or sparc, it's noisy on those platforms >+ # don't use -Wcast-align on hppa, ia64 or sparc, it's noisy on those platforms > # icc doesn't support this flag. > _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wcast-align" > fi This is getting unwieldy, could you refactor this into a case statement? Same thing with the other bit. Other than that, looks ok.
Attachment #322801 -
Flags: review?(ted.mielczarek) → review+
|
|
(Assignee) | |
Comment 3•10 years ago
|
||
Created attachment 324467 [details] [diff] [review] hppa-v2.patch There we go
Attachment #322801 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 4•10 years ago
|
||
Created attachment 324468 [details] [diff] [review] hppa-v3.patch Wrong patch, this is the good one
Attachment #324467 -
Attachment is obsolete: true
|
|
(Assignee) | |
Updated•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Pushed as 15835:101087d57ba5.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
|
||
Updated•8 years ago
|
||
See Also: → https://launchpad.net/bugs/236266
You need to log in
before you can comment on or make changes to this bug.
Description
•