Closed Bug 436133 Opened 12 years ago Closed 11 years ago

Cookies build failure on hppa

Categories

(Core :: Networking: Cookies, defect)

HP
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: armin76, Assigned: armin76)

References

()

Details

Attachments

(1 file, 2 obsolete files)

Same as bug 417345 and bug 411292
Attached patch hppa.patch (obsolete) — Splinter Review
This should do it(i've tested it)
Assignee: nobody → armin76
Status: NEW → ASSIGNED
Attachment #322801 - Flags: review?(ted.mielczarek)
Comment on attachment 322801 [details] [diff] [review]
hppa.patch

>Index: configure.in
>===================================================================
>-    if test "$CPU_ARCH" != "ia64" && test "$CPU_ARCH" != "sparc" \
>+    if test "$CPU_ARCH" != "hppa" && test "$CPU_ARCH" != "ia64" && test "$CPU_ARCH" != "sparc" \
>        && test -z "$INTEL_CC"; then
>-        # don't use -Wcast-align on ia64 or sparc, it's noisy on those platforms
>+        # don't use -Wcast-align on hppa, ia64 or sparc, it's noisy on those platforms
>         # icc doesn't support this flag.
>         _WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wcast-align"
>     fi

This is getting unwieldy, could you refactor this into a case statement? Same thing with the other bit. Other than that, looks ok.
Attachment #322801 - Flags: review?(ted.mielczarek) → review+
Attached patch hppa-v2.patch (obsolete) — Splinter Review
There we go
Attachment #322801 - Attachment is obsolete: true
Attached patch hppa-v3.patchSplinter Review
Wrong patch, this is the good one
Attachment #324467 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed as 15835:101087d57ba5.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.