43637 - userregexp is not applied when creating a new group

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P2)

Description

[Dave Miller [:justdave]]

As the summary says, the userregexp is not applied when creating a new group.  
The user should probably be prompted whether or not they want it applied, and it 
might be nice to also offer to show them a list of users that are already in the 
system that match it also.

Comment 1

[Joe Robins]

This shouldn't be too tough to fix.  Here are two proposed solutions:

1) On the "add" page, add another column to that table, with a checkbox for 
"Apply regexp to existing users".  Default the box to checked, but it can be 
turned off.  If the box is left checked, then apply the userregexp to all 
existing users when the group is created.  (I already did this in 
editproducts.cgi for creating a bug group associated with a product, so I should 
be able to just cut and paste that code, and test it to make sure it works.)

2) After submitting the new group information, pull up a listing of users who 
match the regexp, and query the user for which ones to add to the group.  
Default all checkboxes to checked.  This wouldn't be too tough either, though 
I'd have to do a bit more to break up the code into two separate sections.

I'm in favor of (1), because it's easier, and they can always edit individual 
users later to remove them.  (Or, if bug #43618 gets its way, then they could 
even remove users from the group page afterwards...)  With (2), you're adding an 
extra step to the process, and that's more of a nuisance than it's worth for the 
small benefit.

Let me know what you think, and I can get cracking on this one...

Comment 2

[Dave Miller [:justdave]]

moving to real milestones...

Comment 3

[Andreas Franke (gone)]

-> Bugzilla product, Administration component, reassigning.

Comment 4

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 5

[John Levon]

I was about to file a bug on being able to retroactively apply
the user regexp to existing accounts, not for a new group, but
for the standard ones (in particular canconfirm). Is this request
covered by this bug ?

Comment 6

[Joel Peshkin]

The Right Thing to do here is to keep a distinction between memberships created
by blessing a user and memberships created by evaluating a regexp. (this is much
easier to do in a post bug 68022 world). Once this distinction is present, it
becomes posible to re-evaluate the regexp against the user-base at will. 
Otherwise, once a regexp blesses a uswer, they are stuck there until manually
removed.

Comment 7

[Joel Peshkin]

Groups rewrite in 2.17 fixed this.