436544 - crash while sending empty message from link

Status: RESOLVED DUPLICATE of bug 435881

(Thunderbird :: Message Compose Window, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

I have a PDF file with an email link in it.  When I click on the link, a Tb compose window opens with a recipients field of 

[e-mail]

I switch identities from my default [e-mail] to [e-mail] address, and press send. 

Blam!
 
#0  0x146c1fb1 in nsCharTraits<unsigned short>::length (s=0x0) at nsCharTraits.h:384
#1  0x146c2665 in nsDependentString::nsDependentString (this=0xbfffca9c, data=0x0) at nsTDependentString.h:89
#2  0x146c26a8 in nsDependentString::nsDependentString (this=0xbfffca9c, data=0x0) at nsTDependentString.h:92
#3  0x146c12c5 in nsMsgCompFields::SplitRecipients (this=0x1d971070, recipients=0x0, emailAddressOnly=0, _retval=0xbfffccf4) at /Users/dmose/s/aviary-trunk/mozilla/mailnews/compose/src/nsMsgCompFields.cpp:609
#4  0x003c51df in NS_InvokeByIndex_P (that=0x1d971070, methodIndex=72, paramCount=3, params=0xbfffccd4) at /Users/dmose/s/aviary-trunk/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179
#5  0x15bca69b in XPCWrappedNative::CallMethod (ccx=@0xbfffcf2c, mode=XPCWrappedNative::CALL_METHOD) at /Users/dmose/s/aviary-trunk/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2393
#6  0x15bd4f35 in XPC_WN_CallMethod (cx=0x1d6b7780, obj=0x187f8680, argc=2, argv=0xebb390, vp=0xbfffd06c) at /Users/dmose/s/aviary-trunk/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1473
#7  0x0024f906 in js_Invoke (cx=0x1d6b7780, argc=2, vp=0xebb388, flags=2) at jsinterp.c:1297
#8  0x002429e5 in js_Interpret (cx=0x1d6b7780) at /Users/dmose/s/aviary-trunk/mozilla/js/src/jsinterp.c:4852
#9  0x0024f97b in js_Invoke (cx=0x1d6b7780, argc=1, vp=0xebb224, flags=0) at jsinterp.c:1313
#10 0x0024fc3b in js_InternalInvoke (cx=0x1d6b7780, obj=0x1eacc960, fval=436158880, flags=0, argc=1, argv=0xebb220, rval=0xbfffd98c) at jsinterp.c:1369
#11 0x001f015e in JS_CallFunctionValue (cx=0x1d6b7780, obj=0x1eacc960, fval=436158880, argc=1, argv=0xebb220, rval=0xbfffd98c) at /Users/dmose/s/aviary-trunk/mozilla/js/src/jsapi.c:5054
#12 0x12bb11c0 in nsJSContext::CallEventHandler (this=0x1d6a7d10, aTarget=0x191e0750, aScope=0x15da9ea0, aHandler=0x19ff41a0, aargv=0x1da6f470, arv=0xbfffdb1c) at /Users/dmose/s/aviary-trunk/mozilla/dom/src/base/nsJSEnvironment.cpp:1962
#13 0x12c20c31 in nsJSEventListener::HandleEvent (this=0x191e07e0, aEvent=0x1da7010c) at /Users/dmose/s/aviary-trunk/mozilla/dom/src/events/nsJSEventListener.cpp:248
#14 0x129dfd03 in nsEventListenerManager::HandleEventSubType (this=0x191e0780, aListenerStruct=0x1aa619e8, aListener=0x191e07e0, aDOMEvent=0x1da7010c, aCurrentTarget=0x191e0750, aPhaseFlags=2) at /Users/dmose/s/aviary-trunk/mozilla/content/events/src/nsEventListenerManager.cpp:1080
#15 0x129e19b2 in nsEventListenerManager::HandleEvent (this=0x191e0780, aPresContext=0x1d6b3cd0, aEvent=0xbfffdfc8, aDOMEvent=0xbfffdf00, aCurrentTarget=0x191e0750, aFlags=2, aEventStatus=0xbfffdf04) at /Users/dmose/s/aviary-trunk/mozilla/content/events/src/nsEventListenerManager.cpp:1184
#16 0x12a0dfb2 in nsEventTargetChainItem::HandleEvent (this=0x209c2680, aVisitor=@0xbfffdef8, aFlags=2) at /Users/dmose/s/aviary-trunk/mozilla/content/events/src/nsEventDispatcher.cpp:210
#17 0x12a0e2a6 in nsEventTargetChainItem::HandleEventTargetChain (this=0x209c27e0, aVisitor=@0xbfffdef8, aFlags=6, aCallback=0x0) at /Users/dmose/s/aviary-trunk/mozilla/content/events/src/nsEventDispatcher.cpp:291
#18 0x12a0ea0c in nsEventDispatcher::Dispatch (aTarget=0x1d973070, aPresContext=0x1d6b3cd0, aEvent=0xbfffdfc8, aDOMEvent=0x0, aEventStatus=0xbfffe00c, aCallback=0x0) at /Users/dmose/s/aviary-trunk/mozilla/content/events/src/nsEventDispatcher.cpp:483
#19 0x126ea8d9 in PresShell::HandleDOMEventWithTarget (this=0xee8e00, aTargetContent=0x1d973070, aEvent=0xbfffdfc8, aStatus=0xbfffe00c) at /Users/dmose/s/aviary-trunk/mozilla/layout/base/nsPresShell.cpp:5967
#20 0x128fec36 in nsXULMenuCommandEvent::Run (this=0x1da6f480) at /Users/dmose/s/aviary-trunk/mozilla/layout/xul/base/src/nsXULPopupManager.cpp:2068
#21 0x003aaac2 in nsThread::ProcessNextEvent (this=0x62c3a0, mayWait=0, result=0xbfffe104) at /Users/dmose/s/aviary-trunk/mozilla/xpcom/threads/nsThread.cpp:510
#22 0x00335bdc in NS_ProcessPendingEvents_P (thread=0x62c3a0, timeout=20) at nsThreadUtils.cpp:180
#23 0x15a3c5db in nsBaseAppShell::NativeEventCallback (this=0x15f901c0) at /Users/dmose/s/aviary-trunk/mozilla/widget/src/xpwidgets/nsBaseAppShell.cpp:121
#24 0x159f83fc in nsAppShell::ProcessGeckoEvents (aInfo=0x15f901c0) at /Users/dmose/s/aviary-trunk/mozilla/widget/src/cocoa/nsAppShell.mm:302
#25 0x902c360e in CFRunLoopRunSpecific ()
#26 0x902c3cf8 in CFRunLoopRunInMode ()
#27 0x967e1da4 in RunCurrentEventLoopInMode ()
#28 0x967e1af6 in ReceiveNextEventCommon ()
#29 0x967e1a31 in BlockUntilNextEventMatchingListInMode ()
#30 0x95707505 in _DPSNextEvent ()
#31 0x95706db8 in -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] ()
#32 0x956ffdf3 in -[NSApplication run] ()
#33 0x159f6740 in nsAppShell::Run (this=0x15f901c0) at /Users/dmose/s/aviary-trunk/mozilla/widget/src/cocoa/nsAppShell.mm:591
#34 0x1563333c in nsAppStartup::Run (this=0x15f8fb50) at /Users/dmose/s/aviary-trunk/mozilla/toolkit/components/startup/src/nsAppStartup.cpp:181
#35 0x000f748d in XRE_main (argc=1, argv=0xbffff734, aAppData=0x60d8e0) at /Users/dmose/s/aviary-trunk/mozilla/toolkit/xre/nsAppRunner.cpp:3170
#36 0x0000277b in main (argc=1, argv=0xbffff734) at /Users/dmose/s/aviary-trunk/mozilla/mail/app/nsMailApp.cpp:103

There are two problems here:

1) Since this is an extension-accessible JS API, it should be more resilient to passing in null.

2) Someone is passing in null who shouldn't be.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: bulletproofing/cleanup patch, v1

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Looks like this is already being handled.