437219 - Implement usage of application/app-config.mk and application/app-rules.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert Kaiser]

Benjamin's blog post at http://benjamin.smedbergs.us/blog/2008-05-02/tricks-of-the-mozilla-build-system-myconfigmk-and-myrulesmk/ mentions "Brainstorm of possible improvement: load application/app-config.mk and application/app-rules.mk for application-specific build configuration and build rules."

This would also e.g. enable us to have MOZ_SUITE defined for all .cpp files, so that configure doesn't need to AC_DEFINE it and can get rid of those app-specific things.

Comment 1

[Benjamin Smedberg]

Attachment: app-config.mk and app-rules.mk, rev. 1

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 323916 [details] [diff] [review]
app-config.mk and app-rules.mk, rev. 1

wow, that's easy!

Comment 3

[Benjamin Smedberg]

Pushed to mozilla-central, rev d4910bfb3fab

Comment 4

[Justin Wood (:Callek)]

Ben, would you object to this landing for CVS (1.9.0) users too?

Comment 5

[Benjamin Smedberg]

No, it's pretty risk-free.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 323916 [details] [diff] [review]
app-config.mk and app-rules.mk, rev. 1

a=beltzner

Comment 7

[Justin Wood (:Callek)]

checked in to CVS

Checking in config/config.mk;
/cvsroot/mozilla/config/config.mk,v  <--  config.mk
new revision: 3.390; previous revision: 3.389
done
Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.596; previous revision: 3.595
done