Closed Bug 437219 Opened 12 years ago Closed 12 years ago

Implement usage of application/app-config.mk and application/app-rules.mk

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: kairo, Assigned: benjamin)

References

()

Details

(Keywords: fixed1.9.0.1)

Attachments

(1 file)

Benjamin's blog post at http://benjamin.smedbergs.us/blog/2008-05-02/tricks-of-the-mozilla-build-system-myconfigmk-and-myrulesmk/ mentions "Brainstorm of possible improvement: load application/app-config.mk and application/app-rules.mk for application-specific build configuration and build rules."

This would also e.g. enable us to have MOZ_SUITE defined for all .cpp files, so that configure doesn't need to AC_DEFINE it and can get rid of those app-specific things.
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #323916 - Flags: review?(ted.mielczarek)
Blocks: 437643
Comment on attachment 323916 [details] [diff] [review]
app-config.mk and app-rules.mk, rev. 1

wow, that's easy!
Attachment #323916 - Flags: review?(ted.mielczarek) → review+
Pushed to mozilla-central, rev d4910bfb3fab
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1
Depends on: 438676
Ben, would you object to this landing for CVS (1.9.0) users too?
Flags: wanted1.9.0.x?
No, it's pretty risk-free.
Attachment #323916 - Flags: approval1.9.0.1?
Comment on attachment 323916 [details] [diff] [review]
app-config.mk and app-rules.mk, rev. 1

a=beltzner
Attachment #323916 - Flags: approval1.9.0.1? → approval1.9.0.1+
checked in to CVS

Checking in config/config.mk;
/cvsroot/mozilla/config/config.mk,v  <--  config.mk
new revision: 3.390; previous revision: 3.389
done
Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.596; previous revision: 3.595
done
Flags: wanted1.9.0.x?
Keywords: fixed1.9.0.1
No longer depends on: 438676
Target Milestone: mozilla1.9.1 → mozilla1.9.1a1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.