Closed
Bug 438676
Opened 12 years ago
Closed 12 years ago
Remove xml-rpc from SeaMonkey build
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Not set
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.0a1
People
(Reporter: kairo, Assigned: sgautherie)
References
Details
Attachments
(1 file)
|
4.64 KB,
patch
|
kairo
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Following bug 392845, it sounds a good idea to remove xml-rpc from the SeaMonkey build as well. This also helps with bug 437219, as that extension is not present in mozilla-central.
|
Assignee | |
Comment 1•12 years ago
|
||
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 326605 [details] [diff] [review] (Av1) <suite/*> [Checkin: Comment 6] this looks correct, but I'd like Neil to verify that we want this.
Attachment #326605 -
Flags: superreview?(neil)
Attachment #326605 -
Flags: review?(kairo)
Attachment #326605 -
Flags: review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to comment #0) > This also helps with bug 437219, as that extension is not present in mozilla-central. Actually, this bug blocks bug 437643 rather than bug 437219.
|
||
Comment 4•12 years ago
|
||
Comment on attachment 326605 [details] [diff] [review] (Av1) <suite/*> [Checkin: Comment 6] Well eventually we'll have to remove everything not in mozilla2/extensions/* right?
Attachment #326605 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 5•12 years ago
|
||
Neil: we can still pull repositories from other (separate) projects in there, e.g. chatzilla, venkman or DOMi. All code that is "ours" should live in our own repo instead of mozilla/extensions though, yes. xml-rpc is neither "our" code nor a separate project we care about, I guess, so it's best to just get rid of it :)
|
|
Reporter | |
Comment 6•12 years ago
|
||
checked in, thanks a lot!
|
|
Assignee | |
Comment 7•12 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062615 SeaMonkey/2.0a1pre] (SEA-WIN32-TBOX-trunk) (W2Ksp4) (Zip file) <removed-files> has been updated, but <nsXmlRpcClient.js> is still present, (and <compreg.dat> still references it (and 'xml-rpc')). Are we missing some other change(s), or a clobber, or ... ?
|
|
Assignee | |
Updated•12 years ago
|
Attachment #326605 -
Attachment description: (Av1) <suite/*> → (Av1) <suite/*>
[Checkin: Comment 6]
|
|
Assignee | |
Comment 8•12 years ago
|
||
(In reply to comment #7) > but <nsXmlRpcClient.js> is still present, > (and <compreg.dat> still references it (and 'xml-rpc')). [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008070210 SeaMonkey/2.0a1pre] (SEA-WIN32-TBOX-trunk) (W2Ksp4) [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008070302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•