43735 - Move throbber to the right

Status: VERIFIED WORKSFORME

Description

[Henri Sivonen (:hsivonen)]

Classic theme, build 2000062408

There is unused space between the throbber and the right edge of the window. Expected 
the throbber and the Search button to occupy that space to make the location bar longer.

Comment 1

[Blake Ross]

to ben

Comment 2

[timeless]

would someone please attach a screen capture containing the following:
a. Relevant region of screen w/ red circling or pointing at the specific area.
b. Mock up of what you think should be there instead.
I'm guessing that Classic is actually emulating ie instead of moz in this.  And 
because of the way we're drawing bars I think we have to.  I would not be 
surprised if Ben marks this WONTFIX.

Comment 3

[Jan Varga [:janv]]

Created attachment 12031 [details] [diff] [review]
some changes merged from win to unix

Comment 4

[Jan Varga [:janv]]

Created attachment 12032 [details]
before

Comment 5

[Jan Varga [:janv]]

Created attachment 12033 [details]
after

Comment 6

[Henri Sivonen (:hsivonen)]

This is fixed on Mac. Does the problem persist on other platforms?

Comment 7

[Peter ``jag'' Annema]

Nope, it's fixed on Windows and Unix too. Marking fixed.
Henri, can you take a look at related bug 43124 (throbber not centered) and see
if that is fixed on Mac too with Ben's recent classic fixes (I'm pretty sure it
is)?

Comment 8

[Paul Wyskoczka]

Updated QA contact

Comment 9

[Patty Mac]

Hi Henri,

All platforms (Build: 2000-09-05-08-M18):

This bug is quite unclear to me. Withthis build, there is still 'a 
little' bit unused space between the throbber and the right edge of
the window. It improves a lot. However, does this feature desired that
way? Therefore, I re-open this bug again.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

fixed now.

Comment 11

[Patty Mac]

Unable to verify this bug whether it's fixed or not fixed yet due
to the bug 53805.

Comment 12

[Peter ``jag'' Annema]

Patty, as far as I can tell 53805 only messes up the browser upon skin switching
(does it still?). Quitting the browser then starting it fresh in the desired
skin should work around that.

Comment 13

[Patty Mac]

Peter, bug#53805 is already fixed. However, for this bug# 43735, there is no
more unused space between the throbber and the right edge of the windows.
This is already fixed in classic. In modern, it's still not fixed yet.

Comment 14

[Peter ``jag'' Annema]

Personally I think the (new) modern skin is okay (compared to the "before"
screenshot). Moving the throbber even more over to the right would only make it
look cramped.

Since this is fixed in classic (and in blue) I'm re-assigning this to hewitt.

Hewitt, do you agree modern doesn't need this "fix"?

Comment 15

[Joe Hewitt (gone)]

Yes, Modern is fine and alignment is cozy but not extraneous. We've actually 
debated squeezing the throbber fully into the bottom-right corner, which would 
be space-saving, but a bit too drastic for most people's tastes.

Comment 16

[Peter ``jag'' Annema]

Marking WORKSFORME based on hewitt's comment.

Comment 17

[Patty Mac]

Marking verified based on hewitt's comment.