437934 - Folder tree view does not scroll to visible selected folder, when re-select last-used-folder in editBookmarkPanel

Status: RESOLVED INCOMPLETE

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008060806 Firefox/3.0 Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008060806 Minefield/3.0pre

In Edit This Bookmark panel, and in condition to expand the folder tree view,
When I select last-used-folder in doropdown menu, tree will expand and select the folder.
And when I re-selected the other last-used-folder in doropdown menu, folder tree view does not scroll to visible selected folder.

Reproducible: Always

Steps to Reproduce:
1.At first, register a lot of folders with bookmark.
2.Register some bookmark with different folders, (Preparations last-used-folders)
3.Click Star. Expand tree view.
4.Select a last-used-folder in dropdown menu at folder row.
5.Re-select the other last-used-folder in dropdown menu
Actual Results:  
Folder tree view does not scroll to visible selected folder.(Though the folder is chosen)

Expected Results:  
Folder tree view should scroll to visible selected folder.

Comment 1

[Alice0775 White]

Attachment: patch to chrome://browser/content/places/editBookmarkOverlay.xul

Comment 3

[Marco Bonardo [:mak]]

probably selectItems itself should scroll to the first selected item

Comment 4

[Alice0775 White]

in the Created an attachment (id=324253)

+    if (this._folderTree.currentIndex)
should be
+    if (this._folderTree.currentIndex != -1)

Comment 5

[Blake Winton (:bwinton) (:☕️)]

We added similar code in commit a06095d0da3d.  Could someone re-test this, and let me know whether the bug still occurs?

Thanks,
Blake.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

D'oh.  Wrong product.  Sorry about that.

Comment 8

[Alice0775 White]

Attachment: add ensureRowIsVisible

Call ensureRowIsVisible method after selected a treechildlen

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 511412 [details] [diff] [review]
add ensureRowIsVisible

Mano, what do you think?
Maybe we could evaluate to add a second optional param to select methods to also call ensureRowIsVisible?
Actually selectNode already do that automatically, so it's possible selectItems should just do the same.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 511412 [details] [diff] [review]
add ensureRowIsVisible

selectItems cannot just do the same due to multiple selection, but in the case of single-selection-tree, it can most certainly do so.

Comment 11

[Peter]

Guys, This is an old bug, but currently it is still present. The folder tree does not scroll in edit bookmark at all - this is very frustrating.
What is the correct procedure here, shall i open a new defect or do we reopen this one?