It is very useful to include a timestamp for messages to which a reply is being sent. I was able to search around in the config editor for mailnews.reply_header_authorwrote and use a search engine to figure out that I needed to set this value to 2. I think we should set the default pref to 2 and additionally add UI that would make this preference discoverable and configurable.
Bryan, what do you think about changing this default? I doubt we want UI for this pref, though.
Seems like it could be a good change. What does the timestamp read like? On the configuration side i'd love to promote and help extensions that allow for editing this as some kind of template. But I don't we need a default pref UI for it.
I just realized that I indicated the wrong pref in my initial comment. The actual pref in question here is mailnews.reply_header_type. With this set to 2, the header looks like: On 08/26/2008 01:42 PM, Brandon Sterne wrote: With the default value of 1, the header just says: Brandon Sterne wrote:
That looks ok to me, if there was a patch i'd put in for it.
Taking. I've been using this for years my self!
Karsten, are you interested in mailnews.reply_header_type=2 for seamonkey too?
No, please don't change our default. :)
Created attachment 337710 [details] [diff] [review] proposed fix Ok, let's see if I can tempt Phil with a thunderbird only patch then :)
Comment on attachment 337710 [details] [diff] [review] proposed fix Sure, you've got plenty of ui-r, and I can't argue with the code :)
changeset: 330:6ac5fb23522e http://hg.mozilla.org/comm-central/rev/6ac5fb23522e ->FIXED
First of all, I still prefer the previous default of mailnews.reply_header_type=1 because it is minimalist: IMO, including the timestamp is unnecessarily verbose. In any case, I think mailnews.reply_header_type=2 is (currently) illogical because, AFAICT, it uses the user’s local time zone without including the UTC offset. This makes sense only if all of the user’s correspondents are in the same time zone. Since such a situation is rare, the reply header should include the UTC offset. Names of time zones, such as PDT for -0700, should not be used because time zones, especially DST rules, frequently change for political reasons.