438808 - Thunderbird is unnecessarily including extra locale files and preprocessing others.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I stumbled across these whilst looking at other things:

utilityOverlay.properties:

http://mxr.mozilla.org/seamonkey/search?string=utilityOverlay.properties

This isn't used by anything mail, the xpfe/communicator... stuff isn't part of Thunderbird (we have our own copy of utilityOverlay.js).

nsWindowsHooks.properties:

http://mxr.mozilla.org/seamonkey/search?string=nsWindowsHooks.properties&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=seamonkey
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/xpfe/components/Makefile.in&rev=1.105&mark=103-107#103

Not used (winhooks isn't built by Thunderbird, see second link).

charset.dtd:

http://mxr.mozilla.org/seamonkey/search?string=charset.dtd&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=seamonkey

Not used anywhere

Changes to mail/locales/jar.mn and other-licenses/branding/thunderbird/locales/jar.mn:

brand.dtd and utilityOverlay.dtd don't require preprocessing (nothing gets replaced and you're not meant to preprocess locale files anyway).

Comment 1

[Phil Ringnalda (:philor)]

Comment on attachment 324756 [details] [diff] [review]
The fix

KILL THEM!

Er, ahem. r=philringnalda.

Comment 2

[Mark Banner (:standard8)]

Patch checked in -> fixed.