439125 - Thunderbird installation instructions should ask for left-click only

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

On AMO, the first step in getting and installing an extension is:

1. Right-click the link below and choose "Save Link As..." to download and save the file to your hard disk.

If AMO could notice the case where the User-Agent doing the downloading is different than the app for which the extension is being downloaded, it could send Content-Disposition: attachment with the XPI.  This would force the browser to always save on click, and no context-menu goofiness with explicit instructions would be required.

Comment 1

[Michael Morgan [:morgamic]]

We did this in another bug but ultimately had issues with setting this header -- wenzel you worked on it, do you have more info?

Comment 2

[Fred Wenzel [:wenzel]]

Now I may be mistaken, but I think this *is* how it works. Click it, and then you'll get the right content-disposition header and you can download the file.

What we needed to do for this was serve all non-browser add-ons off the app cluster, because the mirror network won't let us send different headers. Now that we do that, non-browser add-ons are downloaded rather than tried to install.

Of course, some explanation is still needed, so people know how to actually install an add-on.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Sure enough.  Looks like the only thing that needs fixing is point 1 of the instruction verbiage.  Maybe something like:

1. Save the file to your hard disk by clicking the Download Now button below.

Comment 4

[Fred Wenzel [:wenzel]]

I concur. There's no use asking people to right-click if a single click will suffice as well.

Comment 6

[Fred Wenzel [:wenzel]]

This has been fixed in the AMO 5.0.6 redesign.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.mozilla.org/en-US/thunderbird/.