439470 - Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only

Status: VERIFIED FIXED

(MailNews Core :: Address Book, defect, P2)

Description

[Mark Banner (:standard8)]

When examining the properties of a mailing list which is in a linked Mac OS X Address Book, there are two problems:

1) The list of addresses doesn't appear.
2) The dialog appears to be read-write, which it isn't. It should be read-only like we have the main card dialog.

Blocking-TB 3 as this is a highlighted feature.

Comment 1

[Mark Banner (:standard8)]

Attachment: [checked in] Provide read-only detection for mailing list dialogs.

I wanted to come up with something for this before TB 3 alpha 2. This I think is the best I can do without writing a separate read-only dialog, or rewriting how most of it is working.

All the elements are read-only, apart from the list box which is disabled. We can always improve it later if we want to, but I'm hoping we're going to improve the whole dialog, not just the read-only part ;-)

Comment 2

[David :Bienvenu]

Comment on attachment 327403 [details] [diff] [review]
[checked in] Provide read-only detection for mailing list dialogs.

Looks good - one comment nit:

read-only? if so,

should be "If so", not "if so".

Comment 3

[Mark Banner (:standard8)]

The fix for displaying addresses in the list box is in bug 437903.

Comment 4

[Mark Banner (:standard8)]

The second part of this bug (actually listing the addresses in the mailing list dialog) has been fixed by bug 437903 attachment 328102 [details] [diff] [review].

Therefore this bug is also completely fixed.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mark, sorry if I'm wrong but this bug isn't fully fixed. The listbox isn't read-only. I can still use the keyboard to add/modify/delete entries. Ok, after clicking on Ok the changed values weren't applied but IMO the listbox should be disabled.

I'll reopen the bug until you can give a clear statement. It's bad to have two separate issues here.

Comment 6

[Mark Banner (:standard8)]

Attachment: Fix initialisation of directories/mailing lists

So the problem with the code at the moment, is that the maintained lists (of cards) are only filled in when GetChildCards is called. This is giving the effect that if you don't show the properties of the list before you send the email (aka call GetChildCards), then it won't send because it doesn't know about any items in that list.

This patch fixes that by moving the initialisation to the Init function (how original!), and doing the appropriate returns in GetChildCards. I think its still sensible to leave the GetChildCards function sorting out what is actually in the list for queries as that's how the rest of the address book types do it.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 330001 [details] [diff] [review]
Fix initialisation of directories/mailing lists

Opps, wrong bug. I'd better move it across.

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #5)
> Mark, sorry if I'm wrong but this bug isn't fully fixed. The listbox isn't
> read-only. I can still use the keyboard to add/modify/delete entries. Ok, after
> clicking on Ok the changed values weren't applied but IMO the listbox should be
> disabled.

I've filed bug 452192 on this issue, that I'll look at after b1 alongside some other changes I am thinking of.

Therefore closing this bug down.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080830025944 Shredder/3.0b1pre ID:20080830025944

Comment 10

[Wayne Mery (:wsmwk)]

This FIXED bug is flagged with in‑testsuite?   It would be great if assignee or someone else can clear the flag if a test is not appropriate.  And if appropriate, create a test and plus the flag to finish off the bug.