439495 - remove references of "browser.download.manager.useWindow"

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We only use this pref when we alos check .showWhenStarting pref. Seems redundant, so we could get rid of references to it in code.

http://mxr.mozilla.org/seamonkey/source/toolkit/components/downloads/src/nsDownloadProxy.h#50
http://mxr.mozilla.org/seamonkey/source/browser/app/profile/firefox.js#242
http://mxr.mozilla.org/seamonkey/source/toolkit/components/downloads/src/nsDownloadProxy.h#86

http://mxr.mozilla.org/seamonkey/source/mail/app/profile/all-thunderbird.js#327

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Also nixed browser.download.manager.openDelay in firefox.js, which was removed in the fall but not from that file.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 325315 [details] [diff] [review]
v1.0

File a bug on cleaning up the TB prefs, if Phil hasn't already done so?

This pref shows up in Google a fair bit, should make an attempt to fix the wiki references at least.

Comment 3

[Shawn Wilsher :sdwilsh]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/8a770f50ccd3

Updated the following pages:
http://kb.mozillazine.org/About:config_entries#Browser..2A
http://developer.mozilla.org/en/docs/Download_Manager_preferences

Filed bug 442052 for Thunderbird.