442052 - Update preferences for "browser.download.manager.useWindow"

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Shawn Wilsher :sdwilsh]

"browser.download.manager.useWindow" was removed in bug 439495, so thunderbird should remove it from its prefs.js file.

Comment 1

[Philippe M. Chiasson (:gozer)]

Attachment: remove browser.download.manager.useWindows from TB's prefs.js

The preference browser.download.manager.useWindows was removed in bug 439495.
This patch removes it from TB's prefs.js

Comment 2

[Phil Ringnalda (:philor)]

sdwilsh forgot to mention that we should also remove the .openDelay that we were actually using until he pulled it out from under us in bug 389982 :)

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> sdwilsh forgot to mention that we should also remove the .openDelay that we
> were actually using until he pulled it out from under us in bug 389982 :)
I thought I filed a bug on that one... :(

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 326947 [details] [diff] [review]
remove browser.download.manager.useWindows from TB's prefs.js

r=dmose; thanks for the patch!

Comment 5

[Justin Wood (:Callek)]

Shawn, dmose, wouldn't the current setting be desired for Gecko 1.9.0 as long as TB still runs off that? (and can then be removed once it switches to Hg as well).

removing checkin-needed keyword just in case I am right.

Comment 6

[Shawn Wilsher :sdwilsh]

The preference was redundant, which is why it was removed.  Setting the showWhenStarting will accomplish the same effect, and is much clearer.  It shouldn't hurt you to not have the preference defined (defaults to true in 1.9.0)

Comment 7

[Justin Wood (:Callek)]

Thanks, in that case, re-adding checkin-needed

Comment 8

[Mark Banner (:standard8)]

Checking in mail/app/profile/all-thunderbird.js;
/cvsroot/mozilla/mail/app/profile/all-thunderbird.js,v  <--  all-thunderbird.js
new revision: 1.118; previous revision: 1.117
done