439912 - Smart install box should allow "*pre" users to install extension with minVersion $1

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, enhancement, P5)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The smart install box should allow "*pre" users to install extension with minVersion $1, i.e. 3.0pre users to install extension which have 3.0 as minVersion. (Because they have the code of the RCs as nightlies.)

Comment 1

[Fred Wenzel [:wenzel]]

I am not sure this is desired: The unit tests for the original implementation of the version comparator (http://mxr.mozilla.org/mozilla/source/xpcom/tests/TestVersionComparatorRunner.pl) consider 1.1pre lower than 1.1, and this behavior is reflected in the Javascript code too. If authors want their add-on to be compatible with *pre, they need to mark it as such.

As a workaround, you are always able to get the version anyway from the "all versions" page, by the way.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes, 1.1pre is lower than 1.1, but if an RC1 has been released as 1.1, the newer nightlies are still 1.1pre, so you can install the add-on only in an older build.

Comment 3

[Fred Wenzel [:wenzel]]

Hm, I see your point. Have you tried if the add-on manager will actually allow installing an add-on on, say, a 3.0pre nightly when the add-on is marked as compatible with 3.0-... only? If not, there's no use showing a green button on AMO.

Comment 4

[Wayne Mery (:wsmwk)]

archaeopteryx, comment 3?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

No, by default the x.0 application can't install x.0pre add-ons, but you can do this with the extension Nightly Tester Tools. Currently, you can't access the file, IIRC. (There is currently no RC/later pre situtation, meh.)

Comment 6

[Wil Clouser [:clouserw]]

We have an "install anyway" button now.  -> fixed

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I don't see this fixed on production or preview, there is a popup telling to upgrade (sic for RCs and pre nightly builds) or to check the older versions. The 'Install anyway' button is only shown if used appversion > add-on maxVersion, not for <.

Example: https://addons.mozilla.org/en-US/firefox/addon/14228/ (I have no pre Nightly here to test this.)

Comment 8

[Wil Clouser [:clouserw]]

1) Authors should be setting the min version correctly.  This isn't a moving target like maxversion so it shouldn't be hard to do.

2) We want to encourage people to upgrade to the newer versions of Firefox.

I don't want to add additional complexity to already complex code for this edge case.  Calling this wontfix.