440561 - Drag and drop of folders broken

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Rain [:rain1] (inactive)]

With the latest trunk dragging and dropping of folders is broken, at least on Windows (though I suspect on other platforms as well)

version 3.0a2pre (2008061703) -- works
version 3.0a2pre (2008061803) -- broken

Looking at the changelog: http://tinyurl.com/5er7nw it might be a regression from bug 414038 (as that modifies messengerdnd.js), but I'm not sure.

Comment 1

[Rain [:rain1] (inactive)]

I realise I wasn't descriptive enough in the description. :-/

Essentially, it just doesn't work. eg prior to the 18th nightly I could drop any (non-virtual) folder from anywhere into the local Inbox folder, or the local Trash folder. 18th nightly and onwards, I just can't. Apparently the CanDropOnFolderTree function in messengerdnd.js is responsible for testing.

http://mxr.mozilla.org/mozilla/source/mailnews/base/resources/content/messengerdnd.js#53

The changes made to the function in jminta's patch look harmless, though.

Comment 2

[Rain [:rain1] (inactive)]

Taking a closer look, it indeed is a regression from bug 414038.

The logic of this line is reversed:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/base/resources/content/messengerdnd.js&rev=1.66&root=/cvsroot#212

Patch coming up.

Comment 3

[Rain [:rain1] (inactive)]

Attachment: fix [Checkin: Comment 5]

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 325846 [details] [diff] [review]
fix
[Checkin: Comment 5]

r+sr=dmose

Comment 5

[Joshua Cranmer [:jcranmer]]

Checking in mailnews/base/resources/content/messengerdnd.js;
/cvsroot/mozilla/mailnews/base/resources/content/messengerdnd.js,v  <--  messengerdnd.js
new revision: 1.67; previous revision: 1.66
done