Drag and drop of folders broken

RESOLVED FIXED in Thunderbird 3

Status

Thunderbird
Mail Window Front End
--
major
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

({regression})

Trunk
Thunderbird 3
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
With the latest trunk dragging and dropping of folders is broken, at least on Windows (though I suspect on other platforms as well)

version 3.0a2pre (2008061703) -- works
version 3.0a2pre (2008061803) -- broken

Looking at the changelog: http://tinyurl.com/5er7nw it might be a regression from bug 414038 (as that modifies messengerdnd.js), but I'm not sure.
Flags: blocking-thunderbird3.0a2?
(Assignee)

Comment 1

10 years ago
I realise I wasn't descriptive enough in the description. :-/

Essentially, it just doesn't work. eg prior to the 18th nightly I could drop any (non-virtual) folder from anywhere into the local Inbox folder, or the local Trash folder. 18th nightly and onwards, I just can't. Apparently the CanDropOnFolderTree function in messengerdnd.js is responsible for testing.

http://mxr.mozilla.org/mozilla/source/mailnews/base/resources/content/messengerdnd.js#53

The changes made to the function in jminta's patch look harmless, though.
(Assignee)

Comment 2

10 years ago
Taking a closer look, it indeed is a regression from bug 414038.

The logic of this line is reversed:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/base/resources/content/messengerdnd.js&rev=1.66&root=/cvsroot#212

Patch coming up.
OS: Windows Vista → All
Hardware: PC → All
(Assignee)

Updated

10 years ago
Blocks: 414038
(Assignee)

Comment 3

10 years ago
Created attachment 325846 [details] [diff] [review]
fix
[Checkin: Comment 5]
Assignee: nobody → sid1337
Status: NEW → ASSIGNED

Comment 4

10 years ago
Comment on attachment 325846 [details] [diff] [review]
fix
[Checkin: Comment 5]

r+sr=dmose
Attachment #325846 - Flags: superreview+
Attachment #325846 - Flags: review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checking in mailnews/base/resources/content/messengerdnd.js;
/cvsroot/mozilla/mailnews/base/resources/content/messengerdnd.js,v  <--  messengerdnd.js
new revision: 1.67; previous revision: 1.66
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Flags: blocking-thunderbird3.0a2?
Version: unspecified → Trunk
Attachment #325846 - Attachment description: fix → fix [Checkin: Comment 5]
You need to log in before you can comment on or make changes to this bug.