441220 - Port |Bug 183419 – Message Filter dialog and Search dialogs (Message, Address) need close facilities (was buttons)| to Thunderbird

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Serge Gautherie (:sgautherie)]

Per bug 441077 comment 1::
{{
the differences between the two SearchDialog.xul files is not that large, I expect only a couple of bugs need to be ported
}}

*****

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062202 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062003 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

Ctrl+W works for all 3 dialogs.

***

Was bug 183419 patch to fix Mac ("accel") case only ?
Should we port that patch from <mailnews/> to <mail/> ?
Or synchronize this code some other way ?

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> Was bug 183419 patch to fix Mac ("accel") case only ?

I think it was accel-W on all platforms (accel being ctrl, cmd or whatever).

> Should we port that patch from <mailnews/> to <mail/> ?

It works fine for me on Mac as well.

> Or synchronize this code some other way ?

There's only two things I can see that are worth porting in that patch:

1) the onunload/onclose changes in SearchDialog.xul
2) the changes wrt onFilterUnload and onFilterClose in FilterListDialog.js/xul if it is sensible for those to be ported.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <SearchDialog.xul>

Per comment 1 point 1.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <ABSearchDialog.xul>

Same as comment 1 point 1...

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) <(AB)SearchDialog.xul>

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062303 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

Updated (and merged) Av1 and Bv1 patches.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1a) <(AB)SearchDialog.xul>

Cv1, with an additional space/blank line removal.

NB:
This also includes a s/closeWindow(true)/window.close()/g per
<http://mxr.mozilla.org/mailnews/search?string=closeWindow(&find=%5C.xul%24&filter=%5E%5B%5E%5C0%5D*%24&tree=mailnews>

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 326313 [details] [diff] [review]
(Cv1a) <(AB)SearchDialog.xul>

Please don't touch ABSearchDialog.xul here, the changes you are making are being done in bug 441135 already.

- 
         </hbox>
-        

Please drop the second of these whitespace changes as I'd like to keep a blank line there and not add unnecessary confusion to blame.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1b) <(AB)SearchDialog.xul>

Cv1a, with an additional space/blank line removal.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1-SM) <SearchDialog.xul> (sync) cleanup only

Stay in sync' with Cv1b patch.

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Av2-TB) <SearchDialog.xul>

Av1/Cv1b, with comment 6 suggestion(s).

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1-TB) <FilterListDialog.*> [Checkin: Comment 15]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062303 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

Per comment 1 point 2.

NB:
*(mail/) <contextHelp.js> is empty, so useless.
*<utilityOverlay.js> does not seem to be needed !?
 *nor <utilityOverlay.xul>.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 326320 [details] [diff] [review]
(Av2-TB) <SearchDialog.xul>

       </vbox>
-
       <hbox flex="1">

r=me without this change.

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Av2a-TB) <SearchDialog.xul> [Checkin: Comment 15]

Av2-TB, with comment 11 suggestion(s).
To check in.

Comment 13

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1a-SM) <SearchDialog.xul> (sync) cleanup only [Checkin: Comment 15]

Dv1-SM, with comment 11 suggestion(s).
To check in.

Comment 15

[Mark Banner (:standard8)]

Checking in FilterListDialog.js;
/cvsroot/mozilla/mail/base/content/FilterListDialog.js,v  <--  FilterListDialog.js
new revision: 1.20; previous revision: 1.19
done
Checking in FilterListDialog.xul;
/cvsroot/mozilla/mail/base/content/FilterListDialog.xul,v  <--  FilterListDialog.xul
new revision: 1.12; previous revision: 1.11
done
Checking in SearchDialog.xul;
/cvsroot/mozilla/mail/base/content/SearchDialog.xul,v  <--  SearchDialog.xul
new revision: 1.30; previous revision: 1.29
done
Checking in SearchDialog.xul;
/cvsroot/mozilla/mailnews/base/search/resources/content/SearchDialog.xul,v  <--  SearchDialog.xul
new revision: 1.90; previous revision: 1.89
done