441610 - Calling getAttributes() on a defunct object crashes Thunderbird.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Joanmarie Diggs]

Steps to reproduce:

1. Launch Thunderbird
2. Press Enter or double-click on a message to open it
3. Launch Accerciser and select the accessible for the message
   body (role: document frame)
4. Switch to Accerciser's iPython console and type:
   doc = acc.queryDocument()
5. Return to Thunderbird and press Delete to delete the current
   message.
6. Return to the iPython console and type:
   doc.getAttributes()

Thunderbird will crash.

This was discovered while working on an Orca bug.  We're fixing things on the Orca side to not trigger this crash, but Thunderbird still shouldn't crash. :-)

Thanks!

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Check if accessible is still valid

Aaron, is this the right way to fix this?

Comment 2

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-central in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/19e70ca4c2ef

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 326536 [details] [diff] [review]
Check if accessible is still valid

Requesting approval for 1.9.0.x as well. Very safe check for a defunct object.

Comment 4

[Joanmarie Diggs]

Marco:  That has got to be the fastest fix EVER!  You rock sir!  Thanks.

Comment 5

[Marco Zehe (:MarcoZ)]

Hi Joanie,

for the time being and for your own builds, these new style patches get applied using patch -p1, not patch -p0 as CVS patches do. But if you like, you're welcome to use the patch in a build of yours and continue your work with that build until we hopefully get this landed on the 1.9.0.x branch, which is what Thunderbird 3.0a2pre is currently using.

Comment 6

[Marco Zehe (:MarcoZ)]

This would be good to have for Shredder alpha 2, since it can happen anytime that someone:
1. reads a message
2. presses Delete to get rid of it and immediately move to the next one

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 326536 [details] [diff] [review]
Check if accessible is still valid

a=shaver for landing on 1.9.0.x, please add a test as well.

Comment 8

[Marco Zehe (:MarcoZ)]

Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.377; previous revision: 1.376
done