Closed Bug 442358 Opened 12 years ago Closed 12 years ago

jsinterp control flow doesn't flow as specified

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: taras.mozilla, Assigned: mrbkap)

References

Details

(Keywords: fixed1.9.0.2)

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/js/src/jsinterp.cpp#5200 is a return statement and there is another one a few lines down. 

This breaks the rule that code most flow through exit2 at http://mxr.mozilla.org/mozilla-central/source/js/src/jsinterp.cpp#2718
Flags: wanted1.9.1?
Blocks: 443286
No longer blocks: 443286
Attached patch Obvious patchSplinter Review
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #328463 - Flags: review?(igor)
Attachment #328463 - Flags: review?(igor) → review+
Pushed as changeset 32207c9fccb6.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: wanted1.9.1? → wanted1.9.1+
Flags: in-testsuite-
Flags: in-litmus-
Comment on attachment 328463 [details] [diff] [review]
Obvious patch

I'm guessing we want this in 1.9.
Attachment #328463 - Flags: approval1.9.0.2?
Comment on attachment 328463 [details] [diff] [review]
Obvious patch

Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #328463 - Flags: approval1.9.0.2? → approval1.9.0.2+
Fix checked into the 1.9 branch.
Keywords: fixed1.9.0.2
You need to log in before you can comment on or make changes to this bug.