Note: There are a few cases of duplicates in user autocompletion which are being worked on.

jsinterp control flow doesn't flow as specified

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: (dormant account), Assigned: mrbkap)

Tracking

({fixed1.9.0.2})

Trunk
x86
Mac OS X
fixed1.9.0.2
Points:
---
Bug Flags:
wanted1.9.1 +
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

969 bytes, patch
Igor Bukanov
: review+
Samuel Sidler (old account; do not CC)
: approval1.9.0.2+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
http://mxr.mozilla.org/mozilla-central/source/js/src/jsinterp.cpp#5200 is a return statement and there is another one a few lines down. 

This breaks the rule that code most flow through exit2 at http://mxr.mozilla.org/mozilla-central/source/js/src/jsinterp.cpp#2718

Updated

9 years ago
Flags: wanted1.9.1?
(Reporter)

Updated

9 years ago
Blocks: 443286
(Reporter)

Updated

9 years ago
No longer blocks: 443286
(Assignee)

Comment 1

9 years ago
Created attachment 328463 [details] [diff] [review]
Obvious patch
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #328463 - Flags: review?(igor)

Updated

9 years ago
Attachment #328463 - Flags: review?(igor) → review+
(Assignee)

Comment 2

9 years ago
Pushed as changeset 32207c9fccb6.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Flags: wanted1.9.1? → wanted1.9.1+

Updated

9 years ago
Flags: in-testsuite-
Flags: in-litmus-
(Assignee)

Comment 3

9 years ago
Comment on attachment 328463 [details] [diff] [review]
Obvious patch

I'm guessing we want this in 1.9.
Attachment #328463 - Flags: approval1.9.0.2?
Comment on attachment 328463 [details] [diff] [review]
Obvious patch

Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #328463 - Flags: approval1.9.0.2? → approval1.9.0.2+
(Assignee)

Comment 5

9 years ago
Fix checked into the 1.9 branch.
Keywords: fixed1.9.0.2
You need to log in before you can comment on or make changes to this bug.