jsemit control flow doesn't flow as specified

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: (dormant account), Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
http://mxr.mozilla.org/mozilla-central/source/js/src/jsemit.cpp#3055
CHECK_AND_SET_JUMP_OFFSET_AT contains a return statement as breaks the flow described at

http://mxr.mozilla.org/mozilla-central/source/js/src/jsemit.cpp#2988
(Reporter)

Updated

9 years ago
Depends on: 432917
No longer depends on: 442358
(Reporter)

Updated

9 years ago
Blocks: 432917
No longer depends on: 432917
(Reporter)

Comment 1

9 years ago
TODO: dump the CFG from this function to disk to use as a benchmark
(Reporter)

Comment 2

9 years ago
Created attachment 334364 [details] [diff] [review]
Messy decmacroization

Could someone review and commit this or something similar? I can't enforce the must-flow analysis until there are no more bugs in the code.
(Reporter)

Comment 3

9 years ago
Created attachment 336559 [details] [diff] [review]
decmacroization

Wrapped BAD_EXIT in {}
Attachment #336559 - Flags: review?(igor)

Updated

9 years ago
Attachment #336559 - Flags: review?(igor) → review+
(Reporter)

Comment 4

9 years ago
pushed rev 92589edd2e3e
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.