442360 - Drag and drop of folders broken (yet again)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Rain [:rain1] (inactive)]

So drag/drop of folders broke somewhere between 21st and 22nd June.

nightlies:
2008062103 - working
2008062203 - broken

Comment 1

[Rain [:rain1] (inactive)]

Checkins in that time: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=1214045760&maxdate=2008%2F06%2F22+03%3A58%3A49&cvsroot=%2Fcvsroot

Comment 2

[Rain [:rain1] (inactive)]

Reversing the "clean up folder selection v2" patch in bug 414038 fixes this.

Comment 3

[Rain [:rain1] (inactive)]

Attachment: fix [Checkin: Comment 5]

So what's happening is that GetSelectedFolders now returns an array of folder objects instead of one of folder URIs.
http://mxr.mozilla.org/mozilla/source/mailnews/base/resources/content/messengerdnd.js#445

What's happening here:
http://mxr.mozilla.org/mozilla/source/mailnews/base/resources/content/messengerdnd.js#517

is that "id" is a folder object, and instead of the useful folder URI being stored in genTextData, the text "[xpconnect wrapped...]" gets stored.

The fix simply gets the URI in case id is a folder.

Comment 4

[David :Bienvenu]

Comment on attachment 327259 [details] [diff] [review]
fix
[Checkin: Comment 5]

thx, Sid - this fixes the problem for me.

Comment 5

[Phil Ringnalda (:philor)]

mailnews/base/resources/content/messengerdnd.js 1.68