442690 - Locale fallback broken (links to staging article for logged out users)

Status: VERIFIED FIXED

(support.mozilla.org :: Localization, task)

Description

[David Tenser [:djst]]

There is a staging article available in Danish for http://support.mozilla.com/da/kb/Add-ons+are+incompatible+with+Firefox+3. 

What should happen:

For logged out visitors, going to http://support.mozilla.com/da/kb/Add-ons+are+incompatible+with+Firefox+3 should show the en-US article and a notification that a translation is not yet available in Danish. 

What actually happens:

A login box is shown because the Danish staging article is not accessible.


This is a regression. Nelson said in IM that he will work on it tonight.

Comment 1

[Nelson Ko [:nkoth]]

Actually it is not the login box part that is a regression. It is the appearance of links to this article that is the problem. IMO, the login box should appear for contributors that go direct to the URL from their bookmarks or something - this is the easiest way to go back to edit the new staging article.

Anyway, working on making sure no links to such pages appear to people who don't have access to it.

Comment 2

[Nelson Ko [:nkoth]]

I have tested this again. Links on the front page (or any other page/forum post) to this article seem to work correctly to send the user to the fallback page if the newly translated page is still in staging (BUT ONLY IF the locale is in the URL).

I suspect that that the apparent regression is due to bug 439040.

Comment 3

[Nelson Ko [:nkoth]]

Attachment: optional patch to make it always fallback (even if user goes to it from bookmark or notification email)

This is an optional quick fix to make it always fall back when going to the page when not logged in (even if a user uses a bookmark or link in notification email). I am not convinced that this is necessary - but if desired, the patch can be applied.

Comment 4

[David Tenser [:djst]]

Did you intend for me to review it?

Comment 5

[David Tenser [:djst]]

Just tested on staging and it seems to be working properly now. I noticed that it adds bl=n on articles where there is a staging copy available. Is that part of the fix?

Comment 6

[Nelson Ko [:nkoth]]

After discussion, it has been decided to always fallback a non-accessible page to an accessible lang version of it, to ensure that links like http://support.mozilla.com/kb/Page+Name get redirected and then fall back.

This is even if it may then show contributors (that are logged out) the English page of a page that they are working on. They will then have to login to see the page in their language (which is still in staging). Contributors should be able to handle this beyond any initial surprise (hey, how come I am seeing the English page? Oh, I am not logged in...).

patch is in r16587 (trunk) and r16588 (production).

Now, to test if this is robust even without the bl=n, which it should be, then bl=n need not be added (to reduce url lengthiness).

Comment 7

[David Tenser [:djst]]

This bug should be marked as fixed, no?

Comment 8

[Masahiko Imanaka [:marsf]]

Translated article doesn't join to my locale (ja).
Is this behavior related to this bug?

1. Click "Translate this page"
2. Translate and save as staging.
3. The page has saved, but does not join to my locale.
  There is no locale chenge link appears in the bottom right of the page.
  So, I have to join the article to my locale manually.
4. Click history link and select my locale at the bottom of history list.
5. Click "Update Translation" button and set locale.
6. From english page, click "Translate this page" again, then add my translated page as this article's translation.

Comment 9

[Underpass]

Filled a bug just a few minutes ago

https://bugzilla.mozilla.org/show_bug.cgi?id=444995

Comment 10

[Laura Thomson :laura]

Bulk moving open bugs to 0.6.1 

Comment 11

[Nelson Ko [:nkoth]]

This is a different problem -> moved to Bug 447903


(In reply to comment #8)
> Translated article doesn't join to my locale (ja).
> Is this behavior related to this bug?
> 
> 1. Click "Translate this page"
> 2. Translate and save as staging.
> 3. The page has saved, but does not join to my locale.
>   There is no locale chenge link appears in the bottom right of the page.
>   So, I have to join the article to my locale manually.
> 4. Click history link and select my locale at the bottom of history list.
> 5. Click "Update Translation" button and set locale.
> 6. From english page, click "Translate this page" again, then add my translated
> page as this article's translation.
> 

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on production.