442767 - Weave: Entering incorrect passphrase gives no indication of errors

Status: RESOLVED DUPLICATE of bug 505571

(Cloud Services :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce:
 1) Set up a Weave account on one computer (using developer snapshot 0.1.34 from https://labs.mozilla.com/forum/index.php/topic,544.15.html ) 

 2) Install Weave on another computer.

 3) When running Weave for first time on second computer, choose "Sign In", to use your existing account.

 4) Enter the correct username & password, but *intentionally enter the wrong passphrase*.

 5) Complete the rest of the wizard. (I entered a machine name, chose to sync only bookmarks, and then clicked "Next" and then "Next")

EXPECTED RESULTS:
  Weave should *not* accept my bad passphrase. I should have been warned / blocked back at step 4.

ACTUAL RESULTS:
  a) After step 5, Weave shows a brief "Synchronizing your Data...." message, and then shows the final "Thank you! Weave has been installed on this device and your data has been synchronized." <--- the latter part of which is *false*.
  b) Weave shows my username in the taskbar, indicating that I'm successfully logged in
  c) I can sign in & out of weave, with no errors, and I can quit & restart firefox, with no obvious errors
  d) When I quit firefox, I get the little "Syncing with weave... Sync Succeeded" popup message.
  e) ALL of this happens with *zero* visible warning messages.

The only way to tell that something is wrong is to:
  - examine STDERR output
  - check javascript error console
  - check weave logs
Outside of that, I see *no* indication of *anything* being wrong.

Comment 1

[Dan Mills [:thunder]]

Isn't this a duplicate of bug 440888 ?

Comment 2

[Daniel Holbert [:dholbert]]

Bug 440888 ("wizard: validate the passphrase") covers some of this issue, but comment 0 here shows that this is much broader than just an issue in the wizard.  

Weave continues running happily, *telling the user that it's syncing correctly*, when in reality it's using the completely wrong passphrase.

Comment 3

[Daniel Holbert [:dholbert]]

Here's one example of how to trigger this bug, without the wizard being involved at all:
 - Sign out of Weave (using the status-bar icon)
 - Sign in to Weave (using the status-bar icon)
    --> Weave prompts you for your username / password / passphrase
 - Enter a bogus passphrase in this dialog
    --> Weave happily accepts it.  
    --> When I quit firefox, Weave still tells me "sync succeeded"

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: verbose log

Here's Weave's verbose log from the steps described in Comment 0.

Comment 5

[Dan Mills [:thunder]]

The setup wizard now gives an error if the incorrect passphrase is used.

Since most people will have their passphrase saved (the default), this bug should no longer block 0.2.  Retargeting as a normal bug for 0.3.

Comment 6

[Dan Mills [:thunder]]

These bugs need to be triaged, removing 0.3 milestone setting.

Comment 7

[Mike Connor [:mconnor]]

This is pretty bad, fwiw.