442802 - Port rdf-templated search widgets to js

Status: RESOLVED DUPLICATE of bug 878604

(Thunderbird :: Mail Window Front End, defect)

Description

[Joey Minta]

Attachment: patch v1

The only remaining rdf widgets for folders/accounts (other than the folder pane and the account settings tree) are the tree-style pickers defined in mailWidgets.xml.  This patch switches them to be js-driven.  It unfortunately ended up being more verbose than I would have liked, mostly due to a lack of easy to use APIs for getting things like sorted folders/accounts and the list of recent folders.  Obviously we should work toward changing that, but getting rid of rdf is still a higher priority for me.

Comment 1

[David :Bienvenu]

some quick comments:

this patch didn't apply cleanly for mail/base/content/SearchDialog.xul - I had to apply it by hand.

For generate_unread, we don't want to include Junk or Trash folders.

Is the plan that eventually the folder pane will use this widget?

I've applied this patch and am running with it.

When I tried the advanced search dialog, the folder picker's scroll bar didn't work - clicking anywhere in the scroll bar dismissed the menu. The cursor keys didn't do anything either.

Comment 2

[David :Bienvenu]

Comment on attachment 327504 [details] [diff] [review]
patch v1

minusing based on bugs encountered w/ patch.