Created attachment 327505 [details] [diff] [review] v1 Earlier versions of the offline code used the prefetch service to fetch files for the offline cache. This was later moved to nsOfflineCacheUpdate.cpp, but I failed to clean up nsPrefetchService.cpp. Attached patch removes offline fetching from nsPrefetchService.cpp. It leaves the idl alone (to avoid extra breakage in 3.1), but returns NS_ERROR_NOT_IMPLEMENTED if asked to fetch to the offline cache. Next time we're ok to break interfaces, we should remove these methods.
Probably need a bug on removing the methods then, marked blocking the relevant release.
Comment on attachment 327505 [details] [diff] [review] v1 >+++ b/uriloader/prefetch/nsIPrefetchService.idl Mon Jun 30 17:18:00 2008 -0700 > * @param aIncludeNormalItems include normal prefetch items in the list. This arg must be true, or NOT_IMPLEMENTED is thrown, right? > nsPrefetchService::NotifyLoadRequested(nsPrefetchNode *node) >+ const char *topic = "prefetch-load-requested"; Make this static, or just pass the literal to the function directly? There's no need for this temporary. > nsPrefetchService::NotifyLoadCompleted(nsPrefetchNode *node) >+ const char *topic = "prefetch-load-completed"; Same here. r+sr=bzbarsky. Oh, please add -p to your diff options?
Created attachment 334500 [details] [diff] [review] patch to commit
Pushed to mozilla-central as rev bbaf0d5fef61
Bugs 442803, 442806, and 442812 were in the regression range for a places unit test failure and were all backed out in an attempt to fix it.
Re-landed as changeset 90bc3d600db1.