Closed
Bug 442803
Opened 16 years ago
Closed 16 years ago
Remove offline fetching from nsPrefetchService.cpp
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(1 file, 1 obsolete file)
20.12 KB,
patch
|
Details | Diff | Splinter Review |
Earlier versions of the offline code used the prefetch service to fetch files for the offline cache. This was later moved to nsOfflineCacheUpdate.cpp, but I failed to clean up nsPrefetchService.cpp. Attached patch removes offline fetching from nsPrefetchService.cpp. It leaves the idl alone (to avoid extra breakage in 3.1), but returns NS_ERROR_NOT_IMPLEMENTED if asked to fetch to the offline cache. Next time we're ok to break interfaces, we should remove these methods.
Attachment #327505 -
Flags: superreview?(cbiesinger)
Attachment #327505 -
Flags: review?(cbiesinger)
Comment 1•16 years ago
|
||
Probably need a bug on removing the methods then, marked blocking the relevant release.
Assignee | ||
Updated•16 years ago
|
Attachment #327505 -
Flags: review?(bzbarsky)
Comment 2•16 years ago
|
||
Comment on attachment 327505 [details] [diff] [review] v1 >+++ b/uriloader/prefetch/nsIPrefetchService.idl Mon Jun 30 17:18:00 2008 -0700 > * @param aIncludeNormalItems include normal prefetch items in the list. This arg must be true, or NOT_IMPLEMENTED is thrown, right? > nsPrefetchService::NotifyLoadRequested(nsPrefetchNode *node) >+ const char *topic = "prefetch-load-requested"; Make this static, or just pass the literal to the function directly? There's no need for this temporary. > nsPrefetchService::NotifyLoadCompleted(nsPrefetchNode *node) >+ const char *topic = "prefetch-load-completed"; Same here. r+sr=bzbarsky. Oh, please add -p to your diff options?
Attachment #327505 -
Flags: superreview?(cbiesinger)
Attachment #327505 -
Flags: superreview+
Attachment #327505 -
Flags: review?(cbiesinger)
Attachment #327505 -
Flags: review?(bzbarsky)
Attachment #327505 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
Attachment #327505 -
Attachment is obsolete: true
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → dcamp
Assignee | ||
Comment 4•16 years ago
|
||
Pushed to mozilla-central as rev bbaf0d5fef61
Assignee | ||
Comment 5•16 years ago
|
||
Bugs 442803, 442806, and 442812 were in the regression range for a places unit test failure and were all backed out in an attempt to fix it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•16 years ago
|
||
Re-landed as changeset 90bc3d600db1.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•