442803 - Remove offline fetching from nsPrefetchService.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

Earlier versions of the offline code used the prefetch service to fetch files for the offline cache.  This was later moved to nsOfflineCacheUpdate.cpp, but I failed to clean up nsPrefetchService.cpp.

Attached patch removes offline fetching from nsPrefetchService.cpp.  It leaves the idl alone (to avoid extra breakage in 3.1), but returns NS_ERROR_NOT_IMPLEMENTED if asked to fetch to the offline cache.  Next time we're ok to break interfaces, we should remove these methods.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Probably need a bug on removing the methods then, marked blocking the relevant release.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 327505 [details] [diff] [review]
v1

>+++ b/uriloader/prefetch/nsIPrefetchService.idl	Mon Jun 30 17:18:00 2008 -0700
>      * @param aIncludeNormalItems include normal prefetch items in the list.

This arg must be true, or NOT_IMPLEMENTED is thrown, right?

> nsPrefetchService::NotifyLoadRequested(nsPrefetchNode *node)
>+    const char *topic = "prefetch-load-requested";

Make this static, or just pass the literal to the function directly?  There's no need for this temporary.

> nsPrefetchService::NotifyLoadCompleted(nsPrefetchNode *node)
>+    const char *topic = "prefetch-load-completed";

Same here.

r+sr=bzbarsky.

Oh, please add -p to your diff options?

Comment 3

[Dave Camp (:dcamp)]

Attachment: patch to commit

Comment 4

[Dave Camp (:dcamp)]

Pushed to mozilla-central as rev bbaf0d5fef61

Comment 5

[Dave Camp (:dcamp)]

Bugs 442803, 442806, and 442812 were in the regression range for a places unit test failure and were all backed out in an attempt to fix it.

Comment 6

[Dave Camp (:dcamp)]

Re-landed as changeset 90bc3d600db1.