Closed
Bug 442923
Opened 16 years ago
Closed 16 years ago
[kn] Firefox 3 RSS reader setup for Kannada
Categories
(Mozilla Localizations :: kn / Kannada, defect)
Mozilla Localizations
kn / Kannada
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Unassigned)
References
()
Details
(Keywords: fixed1.9.0.5)
Attachments
(1 file, 1 obsolete file)
1.57 KB,
patch
|
stas
:
review+
Pike
:
approval1.9.0.5+
|
Details | Diff | Splinter Review |
RSS readers are web services allowing users to subscribe to RSS feeds online and view them. If Firefox detects a feed, it offers the user to subscribe to it, either as a live bookmark or via one of the web services.
The current RSS Readers in en-US are Bloglines, My Yahoo, Google. In bug 410777, we came up with google reader, possibly yahoo. Should we replace bloglines with netvibes? Not that netvibes is available in Kannada (it's at 0%), but it seems to be more popular in India.
We want to ship a good set of defaults for Kannada, and will work towards that in three stages.
First, the localization team and Mic (Michal Berman) will look at the market for the language and come up with a good candidates. Hari, Shankar, we'll need your input on this, the guidelines for making recommendations are on http://wiki.mozilla.org/Firefox_web_services_guidelines. After we decided on a particular RSS reader, Mic will contact the owner and ask for permission. undefined, we'll likely need your help to at least get the contact information.
Once we have a specification on what the set of RSS readers for Kannada should look like, the localization team and Axel will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Axel. After a successful review, the localization team will land them. If you're not feeling comfortable with creating those changes, ask Axel to help out.
Please don't commit any modifications in l10n/kn/browser/chrome/browser-region/region.properties to the cvs repository without a patch reviewed by Axel or someone else appointed by Mic. The data here is sensitive to users and our search partners, thus the extra care here.
Comment 1•16 years ago
|
||
following on Axel's comments above can we confirm the final list will be:
Google, Yahoo and Netvibes
Comment 2•16 years ago
|
||
Mic,
I too agree with you..
Comment 3•16 years ago
|
||
ok great, we can move forward to close this then. thanks
Reporter | ||
Comment 4•16 years ago
|
||
FIXED.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•16 years ago
|
||
I can't see any landings for this. Region.properties still has Bloglines. Shankar, mind preparing a patch to replace Bloglines with Netvibes?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•16 years ago
|
||
Stas,
Are you talking about cvs system or Hg?
Comment 7•16 years ago
|
||
Since the Kannada cvs code had been already migrated to hg, we'll need to fix this both in cvs and hg. The good news is that we only need one patch, which can be next applied both to cvs and hg. The patch can be from 'cvs diff -u8p' or 'hg diff'.
Do you need any help with hg?
Comment 8•16 years ago
|
||
Stas,
Thanks for the assistance..
I have corrected the region.properties. Got the patch from hg and attached here.
Please let me know if anything else is needed..
Comment 9•16 years ago
|
||
Comment on attachment 346429 [details] [diff] [review]
patch for region.properties
r=me. Please land this patch in hg. For CVS, I'm asking for approval1.9.0.5
One comment:
>+# browser.contentHandlers.types.3.title=Bloglines
>+# browser.contentHandlers.types.3.uri=http://www.bloglines.com/login?r=/sub/%s
I think you can simply remove these lines.
Attachment #346429 -
Flags: review+
Attachment #346429 -
Flags: approval1.9.0.5?
Comment 10•16 years ago
|
||
Stas,
I have removed the those commented lines and created a new patch. Please mark this for approval.
Thanks
Comment 11•16 years ago
|
||
Comment on attachment 346429 [details] [diff] [review]
patch for region.properties
Please see the next attachment
Attachment #346429 -
Attachment is obsolete: true
Attachment #346429 -
Flags: approval1.9.0.5?
Comment 12•16 years ago
|
||
Comment on attachment 346436 [details] [diff] [review]
patch for region.properties
Thanks Shankar. I was assuming that you would make these changes locally before landing the patch, so in fact attaching the new patch wasn't required :) But thanks anyway.
r=me.
One tiny nit: when landing this patch, can you please revert this comment:
>-# This is the default set of web based feed handlers shown in the reader
>-# selection UI
>+# These are the default web service based feed readers
Attachment #346436 -
Flags: review+
Attachment #346436 -
Flags: approval1.9.0.5?
Comment 13•16 years ago
|
||
Stas,
It has been already landed. You can check here: http://hg.mozilla.org/l10n-central/kn/rev/211fe74fd589
Comment 14•16 years ago
|
||
The change looks good. If you could address my comment in comment 12 (with a new push), that would be great. Thanks!
And, congrats on your first hg push! :)
Reporter | ||
Comment 15•16 years ago
|
||
Comment on attachment 346436 [details] [diff] [review]
patch for region.properties
a=me. Please land this with a check-in comment referencing this bug and stas' review/my approval. Something like "bug 442923, RSS reader setup, replace bloglines with netvibes, r=stas, a=l10n@mozilla.com" should work.
Please add the fixed1.9.0.5 keyword when landing, and change it to the verified1.9.0.5 keyword on this bug after testing it on a 3.0.5pre build from ftp.m.o.
Attachment #346436 -
Flags: approval1.9.0.5? → approval1.9.0.5+
Reporter | ||
Comment 16•16 years ago
|
||
Landed on CVS, too.
Checking in region.properties;
/l10n/l10n/kn/browser/chrome/browser-region/region.properties,v <-- region.properties
new revision: 1.4; previous revision: 1.3
done
Marking FIXED and fixed1.9.0.5.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Keywords: fixed1.9.0.5
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•