443161 - Remove incorrect |// Ignore 'autocomplete=off' - available only when wallet.crypto is enabled.|

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Serge Gautherie (:sgautherie)]

(Noticed while looking into bug 425145.)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)

I am successfully using |wallet.crypto.autocompleteoverride = true|,
yet I have never set |wallet.crypto = true|.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-SM) <browser-prefs.js>

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-TB) <all-thunderbird.js>

Comment 3

[Mike Connor [:mconnor]]

Yes, its incorrect because someone broke it.  The pref is meant to only work when a master password is protecting those passwords.  The fact that it doesn't is a pretty crappy bug, IMO.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)

Let's wait for bug 425145 then.

Comment 5

[Philip Chee]

> Yes, its incorrect because someone broke it.  The pref is meant to only work
> when a master password is protecting those passwords.  The fact that it doesn't
> is a pretty crappy bug, IMO.

Hmm. As far as I can tell, this change was deliberate.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 327802 [details] [diff] [review]
(Bv1-TB) <all-thunderbird.js>

Cancelling review request for the time being, as we're waiting for the outcome of different bugs.

Comment 7

[Mike Connor [:mconnor]]

(In reply to comment #5)
> > Yes, its incorrect because someone broke it.  The pref is meant to only work
> > when a master password is protecting those passwords.  The fact that it doesn't
> > is a pretty crappy bug, IMO.
> 
> Hmm. As far as I can tell, this change was deliberate.

Yes, and I think it was a bad decision.  It was bug 154825 and I think it was rather poorly thought through.

Comment 8

[Robert Kaiser]

This bug is open but targeted for seamonkey2.0a1, which has been released a long time ago. Please set the target milestone to an appropriate value, "---" if it has no specific target.