Closed Bug 443161 Opened 16 years ago Closed 15 years ago

Remove incorrect |// Ignore 'autocomplete=off' - available only when wallet.crypto is enabled.|

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Whiteboard: [Bug 390025 and bug 483458 eventually removed both preferences])

Attachments

(2 obsolete files) 

(Noticed while looking into bug 425145.)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)

I am successfully using |wallet.crypto.autocompleteoverride = true|,
yet I have never set |wallet.crypto = true|.
Attached patch (Av1-SM) <browser-prefs.js> (obsolete) — — Splinter Review 
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED

        Attachment #327801 -
        Flags: review?

    
  

        Attachment #327801 -
        Flags: review? → review?(iann_bugzilla)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        (Bv1-TB) <all-thunderbird.js> (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #327802 -
        Flags: review?(bugzilla)

    
  
Depends on: 154825

    
    

    
  
Yes, its incorrect because someone broke it.  The pref is meant to only work when a master password is protecting those passwords.  The fact that it doesn't is a pretty crappy bug, IMO.

    
    

    
  
(In reply to comment #3)

Let's wait for bug 425145 then.
Depends on: 425145
Whiteboard: [Wait and see for bug 425145]

    
    

    
  
> Yes, its incorrect because someone broke it.  The pref is meant to only work
> when a master password is protecting those passwords.  The fact that it doesn't
> is a pretty crappy bug, IMO.

Hmm. As far as I can tell, this change was deliberate.

    
    

    
  
Comment on attachment 327802 [details] [diff] [review]
(Bv1-TB) <all-thunderbird.js>

Cancelling review request for the time being, as we're waiting for the outcome of different bugs.

        Attachment #327802 -
        Flags: review?(bugzilla)

    
  

        Attachment #327801 -
        Flags: review?(iann_bugzilla)

    
    

    
  
(In reply to comment #5)
> > Yes, its incorrect because someone broke it.  The pref is meant to only work
> > when a master password is protecting those passwords.  The fact that it doesn't
> > is a pretty crappy bug, IMO.
> 
> Hmm. As far as I can tell, this change was deliberate.

Yes, and I think it was a bad decision.  It was bug 154825 and I think it was rather poorly thought through.


    
    

    
  
This bug is open but targeted for seamonkey2.0a1, which has been released a long time ago. Please set the target milestone to an appropriate value, "---" if it has no specific target.

    
  
Target Milestone: seamonkey2.0a1 → ---

    
  
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Depends on: 390025, 483458
No longer depends on: 425145
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [Wait and see for bug 425145] → [Bug 390025 and bug 483458 eventually removed both preferences]

    
  

        Attachment #327801 -
        Attachment is obsolete: true

    
  

        Attachment #327802 -
        Attachment is obsolete: true

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: