443358 - Retention: take over user defaults during install on Win32

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Mark Banner (:standard8)]

We need to port bug 392137 to Thunderbird - we should do it prior to the first Beta, as it is an installer issue and we need to do the right thing with defaults.

Comment 1

[Reed Loden [:reed]]

Just please make sure you use SUMMARY_MAKE_DEFAULT instead of SUMMARY_MAKE_DEAFULT. :)

Comment 2

[Robert Strong (they/them - no direct email)]

This will be much simpler with the changes from Bug 404609.

One question that will need to be answered is if you want to provide a separate option for setting as the default News client as well as RSS though bug 445823 would first need to be fixed. It would also be possible to set both at the same time though the current startup check for the default client only checks if it is the default client for Mail.

Comment 3

[David Ascher (:davida)]

I'm not sure I understand the exact details, but Standard8 says we need this for the Tb3 first-start experience.  We should review this along w/ all those issues.

Comment 4

[David :Bienvenu]

moving to b2

Comment 5

[Wayne Mery (:wsmwk)]

this blocker lacks an assignee

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Mark, can you take this one?  Otherwise I'm going to bump this to b3.

If it simplifies the process I think for now we only need to make sure we are taking Mail, we can create new bugs to track getting news and rss done later.

Comment 7

[Robert Strong (they/them - no direct email)]

I could knock this out for Thunderbird pretty quickly if you like. The only question I have is what options to take over defaults you want in the installer since Thunderbird supports both Mail and News. It will also support the feed protocol after bug 445823 is fixed.

So, Mail and News, Mail, or News... just let me know.

Comment 8

[Mark Banner (:standard8)]

(In reply to comment #7)
> I could knock this out for Thunderbird pretty quickly if you like. The only
> question I have is what options to take over defaults you want in the installer
> since Thunderbird supports both Mail and News. It will also support the feed
> protocol after bug 445823 is fixed.

Robert, please feel free to.

> So, Mail and News, Mail, or News... just let me know.

Hopefully Bryan can say what he wants here later.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Provides the option to take over as the default mail application. I'd prefer not having multiple checkboxes (e.g. one to take over as the default mail app and another to take over as the default News app) but it would be trivial to have this take over both... just need the strings for the ui.

Comment 10

[Robert Strong (they/them - no direct email)]

Comment on attachment 360062 [details] [diff] [review]
patch rev1

Bryan, can I get your review on the strings and the behavior you'd like out of the choices available in comment #9? Thanks

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 360062 [details] [diff] [review]
patch rev1

This is great! The strings look fine.  I also wanted to avoid the list of check boxes for each other type in this dialog.

As far as this stands I think the problem is solved for mail.

I'm curious what ideas people have to solve the problem of news and eventually rss defaults.  Is it possible to raise this type of dialog later when someone creates a news or rss account type?

I'm a bit worried about having too many types show up in a single dialog, especially if someone is just installing us for mail.

I switched from the review to ui-review+ since that's normally the box I check off.

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 360062 [details] [diff] [review]
patch rev1

Mark, can you review this?

Comment 13

[Robert Strong (they/them - no direct email)]

(In reply to comment #11)
> (From update of attachment 360062 [details] [diff] [review])
> This is great! The strings look fine.  I also wanted to avoid the list of check
> boxes for each other type in this dialog.
> 
> As far as this stands I think the problem is solved for mail.
> 
> I'm curious what ideas people have to solve the problem of news and eventually
> rss defaults.  Is it possible to raise this type of dialog later when someone
> creates a news or rss account type?
I would avoid trying to duplicate this ui which is in the Win32 installer and instead duplicate the existing defaults dialog in the app since it should be consistent across all platforms where possible.

As for bringing up the default check when new news or rss accounts are created I'm sure it is possible to bring up the set as default ui. Keep in mind that bug 445823 needs to be fixed to support feeds / rss shell integration.

Comment 14

[Mark Banner (:standard8)]

Ok, I now think I know why I filed this bug, and it needed to be blocking betas. However, I was wrong at the time, and what I meant to be blocking was implemented by bug 404609 (the bit where we don't install betas over the user's directory). Still, this is a nice win for user installation and we should be doing it anyway.

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 360062 [details] [diff] [review]
patch rev1

This looks fine to me, I tried out a few tests and couldn't find anything wrong. Thanks Robert.

Comment 16

[Robert Strong (they/them - no direct email)]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/0e8807902dde