Closed Bug 443358 Opened 16 years ago Closed 15 years ago

Retention: take over user defaults during install on Win32

Categories

(Thunderbird :: Installer, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: robert.strong.bugs)

References

Details

(Whiteboard: [has l10n impact])

Attachments

(1 file)

We need to port bug 392137 to Thunderbird - we should do it prior to the first Beta, as it is an installer issue and we need to do the right thing with defaults.
Flags: blocking-thunderbird3?
Whiteboard: [needs to block beta1]
Just please make sure you use SUMMARY_MAKE_DEFAULT instead of SUMMARY_MAKE_DEAFULT. :)
This will be much simpler with the changes from Bug 404609.

One question that will need to be answered is if you want to provide a separate option for setting as the default News client as well as RSS though bug 445823 would first need to be fixed. It would also be possible to set both at the same time though the current startup check for the default client only checks if it is the default client for Mail.
I'm not sure I understand the exact details, but Standard8 says we need this for the Tb3 first-start experience.  We should review this along w/ all those issues.
Flags: blocking-thunderbird3? → blocking-thunderbird3+
moving to b2
Target Milestone: --- → Thunderbird 3.0b2
Whiteboard: [needs to block beta1] → [needs to block beta2]
this blocker lacks an assignee
Mark, can you take this one?  Otherwise I'm going to bump this to b3.

If it simplifies the process I think for now we only need to make sure we are taking Mail, we can create new bugs to track getting news and rss done later.
Assignee: nobody → bugzilla
Whiteboard: [needs to block beta2] → [needs to block beta2][unclear l10n impact]
I could knock this out for Thunderbird pretty quickly if you like. The only question I have is what options to take over defaults you want in the installer since Thunderbird supports both Mail and News. It will also support the feed protocol after bug 445823 is fixed.

So, Mail and News, Mail, or News... just let me know.
(In reply to comment #7)
> I could knock this out for Thunderbird pretty quickly if you like. The only
> question I have is what options to take over defaults you want in the installer
> since Thunderbird supports both Mail and News. It will also support the feed
> protocol after bug 445823 is fixed.

Robert, please feel free to.

> So, Mail and News, Mail, or News... just let me know.

Hopefully Bryan can say what he wants here later.
Assignee: bugzilla → robert.bugzilla
Attached patch patch rev1Splinter Review
Provides the option to take over as the default mail application. I'd prefer not having multiple checkboxes (e.g. one to take over as the default mail app and another to take over as the default News app) but it would be trivial to have this take over both... just need the strings for the ui.
Attachment #360062 - Flags: review?(clarkbw)
Comment on attachment 360062 [details] [diff] [review]
patch rev1

Bryan, can I get your review on the strings and the behavior you'd like out of the choices available in comment #9? Thanks
Comment on attachment 360062 [details] [diff] [review]
patch rev1

This is great! The strings look fine.  I also wanted to avoid the list of check boxes for each other type in this dialog.

As far as this stands I think the problem is solved for mail.

I'm curious what ideas people have to solve the problem of news and eventually rss defaults.  Is it possible to raise this type of dialog later when someone creates a news or rss account type?

I'm a bit worried about having too many types show up in a single dialog, especially if someone is just installing us for mail.

I switched from the review to ui-review+ since that's normally the box I check off.
Attachment #360062 - Flags: review?(clarkbw) → ui-review+
Comment on attachment 360062 [details] [diff] [review]
patch rev1

Mark, can you review this?
Attachment #360062 - Flags: review?(bugzilla)
Whiteboard: [needs to block beta2][unclear l10n impact] → [needs to block beta2][unclear l10n impact][has patch for review]
(In reply to comment #11)
> (From update of attachment 360062 [details] [diff] [review])
> This is great! The strings look fine.  I also wanted to avoid the list of check
> boxes for each other type in this dialog.
> 
> As far as this stands I think the problem is solved for mail.
> 
> I'm curious what ideas people have to solve the problem of news and eventually
> rss defaults.  Is it possible to raise this type of dialog later when someone
> creates a news or rss account type?
I would avoid trying to duplicate this ui which is in the Win32 installer and instead duplicate the existing defaults dialog in the app since it should be consistent across all platforms where possible.

As for bringing up the default check when new news or rss accounts are created I'm sure it is possible to bring up the set as default ui. Keep in mind that bug 445823 needs to be fixed to support feeds / rss shell integration.
Whiteboard: [needs to block beta2][unclear l10n impact][has patch for review] → [needs to block beta2][has l10n impact][has patch for review]
Whiteboard: [needs to block beta2][has l10n impact][has patch for review] → [needs to block beta2][has l10n impact][has patch for review standard8]
Ok, I now think I know why I filed this bug, and it needed to be blocking betas. However, I was wrong at the time, and what I meant to be blocking was implemented by bug 404609 (the bit where we don't install betas over the user's directory). Still, this is a nice win for user installation and we should be doing it anyway.
Whiteboard: [needs to block beta2][has l10n impact][has patch for review standard8] → [has l10n impact][has patch for review standard8]
Comment on attachment 360062 [details] [diff] [review]
patch rev1

This looks fine to me, I tried out a few tests and couldn't find anything wrong. Thanks Robert.
Attachment #360062 - Flags: review?(bugzilla) → review+
Whiteboard: [has l10n impact][has patch for review standard8] → [has l10n impact][ready to land]
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/0e8807902dde
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [has l10n impact][ready to land] → [has l10n impact]
You need to log in before you can comment on or make changes to this bug.