443367 - test_bug394717 uses timeouts and the network which leads to intermittent failures

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Attachment: patch rev 1

test_bug394717 starts an update check for all installed add-ons and then delays to see if the check completed correctly. This is bogus, the more add-ons that are present the longer this will take and additionally it is letting the update checks go out to the network which is not a good idea for a deterministic test.

Seamonkey is hitting intermittent failures on this due to the presence of some 6 default add-ons present, some of which are checking for updates from AMO.

This simple patch removes the timeout and simply calls the final checks in the last callback from the update check. It also adds the test server ad makes default update pings go there to avoid touching the network.

Comment 1

[Dave Townsend [:mossop]]

Landed in changeset 5024aedbb16d

Comment 2

[Robert Kaiser]

Thanks, could you land on 1.9.0 as well, as SeaMonkey for now is still living and running tests from there?

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> Thanks, could you land on 1.9.0 as well, as SeaMonkey for now is still living
> and running tests from there?

Yeah, still waiting on something vaguely resembling a green tree.

Comment 4

[Dave Townsend [:mossop]]

Landed on 1.9.0 branch

Checking in toolkit/mozapps/extensions/test/unit/test_bug394717.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug394717.js,v  <--  test_bug394717.js
new revision: 1.3; previous revision: 1.2
done