443484 - In <prefs.js>, "Error: client.ceip is undefined" on first run

Status: VERIFIED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a1pre) Gecko/2008070303 Minefield/3.1a1pre] (nightly) (W2Ksp4)

No bug. (CZ v0.9.83)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008070302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

First start (only) of CZ for a given profile:
{{
Error: client.ceip is undefined
Source File: chrome://chatzilla/content/prefs.js
Line: 830
}}

+/- related to bug 432216 !?

Comment 1

[Glen Mailer]

Attachment: quick-fix patch

I cant really be bothered to figure out *why* this is occurring right now, but since I got as far as opening the file and reading the offending line, here's a patch that will fix this.

Comment 2

[James Ross]

Bug 432216 isn't related AFAIK. Also, I'm not accepting a patch like that.

Can someone catch this in a debugger (preferably Venkman), and see what the stack is?

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)

{{
#0: function onPrefChanged(oldValue=string:"", newValue=string:"A890seYGyQTJoCwEz8dRXAYmxcs8qgs9", prefName=string:"ceip.userid") in <chrome://chatzilla/content/prefs.js> line 830
#1: function pm_prefchanged(oldValue=string:"", realValue=string:"A890seYGyQTJoCwEz8dRXAYmxcs8qgs9", prefName=string:"ceip.userid") in <chrome://chatzilla/content/lib/js/pref-manager.js> line 193
#2: function pm_observe(prefName=string:"ceip.userid", topic=string:"nsPref:changed", prefService=XPComponent:{1}) in <chrome://chatzilla/content/lib/js/pref-manager.js> line 69
 3: setCharPref / x-jsd:native-code
#4: function pm_setpref(value=string:"A890seYGyQTJoCwEz8dRXAYmxcs8qgs9", prefName=string:"ceip.userid") in <chrome://chatzilla/content/lib/js/pref-manager.js> line 436
#5: function prefSetter(value=string:"A890seYGyQTJoCwEz8dRXAYmxcs8qgs9") in <chrome://chatzilla/content/lib/js/pref-manager.js> line 466
#6: function CEIP() in <chrome://chatzilla/content/ceip/ceip.js> line 11
#7: function initInstrumentation() in <chrome://chatzilla/content/static.js> line 576
#8: function init() in <chrome://chatzilla/content/static.js> line 220
#9: function onLoad() in <chrome://chatzilla/content/handlers.js> line 92
#10: function onload(event=Event:{0}) in <chrome://chatzilla/content/chatzilla.xul> line 1
}}

Comment 4

[Glen Mailer]

As far as i can tell, the initialisation of the CEIP object is setting the pref for the user id, which fires the prefchanged handler, which then tried to notify the ceip object that the prefs have changed - but since the object hasn't finished creation it fails.

why this happens here, and why it doesn't happen normally is beyond me however :(

Comment 5

[James Ross]

Glen, the user id is set only once, so it would only affect the first start with a CEIP-enabled version of ChatZilla in a given profile.

Comment 6

[James Ross]

Attachment: Only notify CEIP about log pref changes [Checkin: Comment 8]

Comment 7

[:Gijs (he/him)]

Comment on attachment 328209 [details] [diff] [review]
Only notify CEIP about log pref changes
[Checkin: Comment 8]

r=me

(Sorry about the amazing delay in reviews, as I hope I made clear I was on holidays until now...)

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 328209 [details] [diff] [review]
Only notify CEIP about log pref changes
[Checkin: Comment 8]


2008-09-09 11:49	silver%warwickcompsoc.co.uk 	mozilla/extensions/irc/xul/content/prefs.js 	1.56

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed between
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080909002343 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080910003607 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)