443919 - Webapps created through Prism bookmarklet fail to install on linux

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Antonio Gomes (tonikitoo)]

* Test environment: prism built on the source (r16770) using FF3.1 as build system.

* Steps:

1) Download a user contributor bundles webapp (http://wiki.mozilla.org/Prism#User_Contributed_Bundles) or any webapp created through http://prismspectrum.com/bookmarklet/

2) Try to install the webapp from the command line

   $ ./prism -webapp <path_to_webapp_file>

ACTUAL OUTCOME:

* line 

FileIO.stringToFile(cmd, appINI);

in method accept (WebAppInstall.jsm), throws a permission denied exception:

[Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFileOutputStream.init]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: file:///home/agomes/prism/mozilla-build-system/mozilla/objdir/prism/dist/bin/extensions/[e-mail]/modules/WebAppProperties.jsm :: anonymous :: line 246"  data: no]createApplication 3

Comment 1

[Antonio Gomes (tonikitoo)]

Hum, after a quick dig into this, just notice the following:

if I manually unpack (unzip) any of the webapps [1] generated by the prism_bookmarklet [2], the webapp.ini file in it after poor permissions:

agomes@tonix:~/.webapps$ find -name webapp.ini | xargs ls -l 
-r-------- 1 agomes agomes 147 2008-05-27 20:09 ./[e-mail]/webapp.ini

Same perms if I watch the temporary file created by newapp/modules/WebAppInstall.jsm#createApplication() method in /tmp.

[1] http://prismspectrum.com/refraction/webapps/?C=M;O=D
[2] http://prismspectrum.com/bookmarklet/get.php?title=Index%2520of%2520/refraction/webapps&description=&link=http%253A//prismspectrum.com/refraction/webapps/%253FC%253DM%253BO%253DD




taking bug ...

Comment 2

[Antonio Gomes (tonikitoo)]

Attachment: patch v0.1

Check if webapp.ini has enough writtting permissions before FileIO.StringToFile.

If it is not writable, set it as such.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Completed: At revision: 19015