Closed Bug 444013 Opened 12 years ago Closed 12 years ago
Centralize win32 theme implementation
Currently there is duplicated code in nsNativeThemeWin and nsLookAndFeel which should be consolidated into one location.
Summary: Centralize win32 theme implemenation → Centralize win32 theme implementation
Creates a nsNativeThemeData class which is initialized once for the entire application.
Assignee: nobody → tellrob
Status: NEW → ASSIGNED
Attachment #329127 - Flags: review?(vladimir)
As discussed over IRC, renamed nsNativeThemeData to nsUXThemeData and made all the members static. Also fixed a bug where the text colors for Media and Communications toolbars was incorrect.
I'd also move mFlatMenus and the detection of the Windows version to nsNativeThemeData since those are also duplicated.
Moved version checks and flat menu detection into nsUXThemeData. Also renamed nsNativeThemeConstants.h to nsUXThemeConstants.h
Attachment #329151 - Flags: review?(vladimir) → review+
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/68ddc8f23721
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
The checkin for this bug caused a regression where Firefox crashes on shutdown, see bug 448104.
You need to log in before you can comment on or make changes to this bug.