Closed
Bug 444013
Opened 12 years ago
Closed 12 years ago
Centralize win32 theme implementation
Categories
(Core :: Widget: Win32, defect)
Not set
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: robarnold, Assigned: robarnold)
References
Details
Attachments
(1 file, 2 obsolete files)
59.78 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
Currently there is duplicated code in nsNativeThemeWin and nsLookAndFeel which should be consolidated into one location.
Assignee | ||
Updated•12 years ago
|
Summary: Centralize win32 theme implemenation → Centralize win32 theme implementation
Assignee | ||
Comment 1•12 years ago
|
||
Creates a nsNativeThemeData class which is initialized once for the entire application.
Assignee | ||
Comment 2•12 years ago
|
||
As discussed over IRC, renamed nsNativeThemeData to nsUXThemeData and made all the members static. Also fixed a bug where the text colors for Media and Communications toolbars was incorrect.
Attachment #329127 -
Attachment is obsolete: true
Attachment #329145 -
Flags: review?(vladimir)
Attachment #329127 -
Flags: review?(vladimir)
I'd also move mFlatMenus and the detection of the Windows version to nsNativeThemeData since those are also duplicated.
Assignee | ||
Comment 4•12 years ago
|
||
Moved version checks and flat menu detection into nsUXThemeData. Also renamed nsNativeThemeConstants.h to nsUXThemeConstants.h
Attachment #329145 -
Attachment is obsolete: true
Attachment #329151 -
Flags: review?(vladimir)
Attachment #329145 -
Flags: review?(vladimir)
Attachment #329151 -
Flags: review?(vladimir) → review+
Comment 5•12 years ago
|
||
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/68ddc8f23721
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
The checkin for this bug caused a regression where Firefox crashes on shutdown, see bug 448104.
You need to log in
before you can comment on or make changes to this bug.
Description
•