444007 - Redesign theme API

Status: RESOLVED INCOMPLETE

(Core :: Widget, defect)

Description

[Rob Arnold [:robarnold]]

nsLookAndFeel and nsNativeThemeWin each contain duplicate code for dynamically loading uxtheme.dll and extracting the theme functions and handles. Aero glass needs the ability to query theme data (color specifically) from nsWindow in its fallback case. This logic and data should be centralized somewhere and easily accessible.

While we're at it bug 392644 would be easier to fix with animation support built in to the theme APIs. OSX also needs some animation support for its widgets.

And some of that code is pretty old and could stand to be cleaned up.

Comment 1

[Rob Arnold [:robarnold]]

Bug 444013 reduced the duplicate code. I think that nsILookAndFeel and nsITheme should be merged since all our supported platforms provide an nsITheme implementation (and a default one is fairly easy).