444319 - toolkit --help lists non-working -height and -width options, but they don't work in most apps

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Jim Rees]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008061015 Firefox/3.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008061015 Firefox/3.0

"firefox --help" lists the "height" and "width" command line options, which haven't worked in a decade and seem unlikely to work in the future (see bug #20573). These options should be removed.

Reproducible: Always

Steps to Reproduce:
1.Run "firefox --help"
Actual Results:  
"height" and "width" command line options are listed

Expected Results:  
These options should not be listed, and if given should be rejected

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Don't list -height and -width options in the help since they aren't working anyway.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Why don't they work? Is there a bug filed (bug 20573 is unrelated as far as I can tell)? Looking at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/nsBrowserContentHandler.js&rev=1.49&mark=626-632#621 I don't see offhand why they wouldn't.

Comment 3

[Magnus Melin [:mkmelin]]

I don't know why it doesn't work, but it doesn't and seeing the age of bug 50201 apparently haven't at least since 2000. I just retested it both in gnome and kde, they have no effect whatsoever. 

In thunderbird i get "Warning: unrecognized command line flag -height".

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 329327 [details] [diff] [review]
proposed fix

OK. I guess these should be handled in app-specific handlers anyways (and therefore added to their nsICommandLineHandler's helpInfo once they work there). Can you file bugs on Firefox and Thunderbird on fixing these? Bug 50201 should probably be turned into a SeaMonkey bug.

Comment 5

[Magnus Melin [:mkmelin]]

Created follow-up bugs bug 450852 and bug 450853. 

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Magnus: so this is ready to land, right?

Comment 7

[Magnus Melin [:mkmelin]]

Yes, i've just be been away/busy. +no good tree when i'd have had the time to land it.

Comment 8

[Magnus Melin [:mkmelin]]

changeset:   18374:588b9a776ce8
http://hg.mozilla.org/index.cgi/mozilla-central/rev/588b9a776ce8

->FIXED

Comment 9

[Magnus Melin [:mkmelin]]

Removed the options from the dev pages. This was the earlier version:
http://developer.mozilla.org/index.php?title=En/Command_Line_Options&revision=20