Closed Bug 444489 Opened 12 years ago Closed 11 years ago

UpdateLayeredWindow bad prototype in widget/src/windows/nsWindow.cpp

Categories

(Core :: Widget: Win32, defect)

x86
Windows CE
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wolfe, Assigned: wolfe)

References

Details

(Keywords: mobile)

Attachments

(1 file, 1 obsolete file)

For Windows Builds, UpdateLayeredWindow prototype is good enough to build and run correctly.

For WINCE builds, the prototype mismatch can produce bogus calling code in nsWindow.cpp.
Attachment #328796 - Attachment is patch: true
Attachment #328796 - Attachment mime type: application/octet-stream → text/plain
Component: General → Widget: Win32
Product: Fennec → Core
QA Contact: general → win32
Version: 1.0 → Trunk
Keywords: mobile
Attachment #328796 - Flags: review?(emaijala)
Attachment #328796 - Attachment is obsolete: true
Attachment #328796 - Flags: review?(emaijala)
Comment on attachment 329598 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I mistakenly removed the review flag when I updated the patch from DIFF CONTEXT to DIFF UNIFIED.  Sorry for the confusion.
Attachment #329598 - Flags: review?(emaijala)
Comment on attachment 329598 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

This is for Firefox 2, not trunk, right? Got me confused for a while trying to find the relevant place in trunk nsWindow.cpp.
Attachment #329598 - Flags: review?(emaijala) → review+
Keywords: checkin-needed
Wolfe: the code you patch no longer exists, need to revist this.
Assignee: nobody → wolfe
Keywords: checkin-needed
Blocks: 432792
Looks like prototype for UpdateLayeredWindow is no longer required at the top of widget/src/windows/nsWindow.cpp -- so this patch is no longer required for building WinCE/WinMobile.

This bug can be marked as RESOLVED.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.