444489 - UpdateLayeredWindow bad prototype in widget/src/windows/nsWindow.cpp

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Fixes UpdateLayeredWindow prototype for WinCE builds

For Windows Builds, UpdateLayeredWindow prototype is good enough to build and run correctly.

For WINCE builds, the prototype mismatch can produce bogus calling code in nsWindow.cpp.

Comment 1

[John Wolfe (:wolfe)]

Attachment: Same DIFF, just done in Unified instead of Context formatting

Comment 2

[John Wolfe (:wolfe)]

Comment on attachment 329598 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I mistakenly removed the review flag when I updated the patch from DIFF CONTEXT to DIFF UNIFIED.  Sorry for the confusion.

Comment 3

[Ere Maijala (slow)]

Comment on attachment 329598 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

This is for Firefox 2, not trunk, right? Got me confused for a while trying to find the relevant place in trunk nsWindow.cpp.

Comment 4

[Makoto Kato [:m_kato]]

This code is removed by Bug 444679.
http://hg.mozilla.org/mozilla-central/index.cgi/rev/c5e52a5ef92b

You should dup of bug 444679

Comment 5

[Stuart Parmenter]

Wolfe: the code you patch no longer exists, need to revist this.

Comment 6

[John Wolfe (:wolfe)]

Looks like prototype for UpdateLayeredWindow is no longer required at the top of widget/src/windows/nsWindow.cpp -- so this patch is no longer required for building WinCE/WinMobile.

This bug can be marked as RESOLVED.