444809 - Incorrect login doesn't persist redirect parameter

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Brian Krausz]

If you provide an invalid password and then a valid one on the second try, you lose the redirect and are sent to the homepage.

Comment 1

[smita]

Attachment: Patch for Bug 44809

Couldn't assign the bug to myself.
But I have fixed it.

Comment 2

[Fred Wenzel [:wenzel]]

Comment on attachment 351734 [details] [diff] [review]
Patch for Bug 44809

Can you indent your code with four spaces (per indentation level) please, and not tab characters?

Comment 3

[smita]

Attachment: Patch for Bug 444809 after review comments

Updated patch as per comment #2

Comment 4

[Ryan Doherty (:rdoherty)]

Comment on attachment 351735 [details] [diff] [review]
Patch for Bug 444809 after review comments

Looks good to me!

Comment 5

[Fred Wenzel [:wenzel]]

Another patch just waiting for checkin. I believe Ryan needs to do that, as smita has no commit access?

Comment 6

[smita]

I do have commit access.I will commit it today.

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #6)
> I do have commit access.

Oops, sorry. Can you pick the bugs back up that I assigned to rdoherty now? Thanks.

Comment 8

[Ryan Doherty (:rdoherty)]

r24773

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the STR in comment 0, and https://preview.addons.mozilla.org/en-US/firefox/users/login?to=%2Freviews%2Fadd%2F219.